-
Notifications
You must be signed in to change notification settings - Fork 181
JP-3246 added link to top webpage to JWST helpdesk #7610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@howard I followed how other topics are linked to pages in the top index.rst and added a If this is not how you want the help desk link added to top page let me know and I will change it/. |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #7610 +/- ##
=======================================
Coverage 77.01% 77.01%
=======================================
Files 456 456
Lines 36625 36625
=======================================
Hits 28208 28208
Misses 8417 8417
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
hbushouse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if having this new entry tucked way down at the end of the list of top-level sections that can be clicked on will render it semi-invisible to most people. I think it would be more visible and easier to implement if we just added the text (as its own short paragraph) right after the opening "Welcome to the ..." paragraph at the top of the main RTD page. So you wouldn't need the extra .rst files for that.
hbushouse
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The updated doc page builds correctly and the link is active.
Resolves JP-3246
Closes #
This PR adds a link to JWST help desk to the JWST pipeline line landing page.
Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR