Skip to content

Conversation

@tapastro
Copy link
Contributor

@tapastro tapastro commented Apr 27, 2023

Resolves JP-nnnn

Closes #

This PR addresses outdated usage of the jump threshold parameter, which was renamed to rejection_threshold.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@tapastro tapastro added this to the Build 9.3 milestone Apr 27, 2023
@tapastro tapastro requested a review from a team as a code owner April 27, 2023 14:26
@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (269bedc) 77.56% compared to head (559e5cc) 77.56%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7572   +/-   ##
=======================================
  Coverage   77.56%   77.56%           
=======================================
  Files         455      455           
  Lines       36340    36340           
=======================================
  Hits        28188    28188           
  Misses       8152     8152           
Flag Coverage Δ *Carryforward flag
nightly 77.62% <ø> (ø) Carriedforward from 269bedc

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@hbushouse hbushouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hbushouse hbushouse merged commit 5fdad6f into spacetelescope:master Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants