re-add latest-commit installs of stdatamodels and stcal #7547
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
automation
Collaborator
Author
hbushouse
approved these changes
Apr 12, 2023
Collaborator
There was a problem hiding this comment.
The test log shows that it's again using the master branches of stcal and stdatamodels, so it looks like this works as intended.
Although we should also confirm that when we do a release with a populated version of requirements-sdp.txt it does NOT use the master branches.
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #7547 +/- ##
=======================================
Coverage 77.86% 77.86%
=======================================
Files 452 452
Lines 36203 36203
=======================================
Hits 28189 28189
Misses 8014 8014
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the discrepancies in truth files from the change in #7544 ; it appears that using an additional call to
pip install -r requirements-sdp.txtwithin the build command is a valid workaround for the previously stated issue.Checklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR