use minimum_dependencies package instead of script
#7463
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 77.53% // Head: 77.53% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #7463 +/- ##
=======================================
Coverage 77.53% 77.53%
=======================================
Files 450 450
Lines 36061 36061
=======================================
Hits 27959 27959
Misses 8102 8102
*This pull request uses carry forward flags. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
zacharyburnett
force-pushed
the
minimum_dependencies
branch
from
87cc853 to
ef1d089
Compare
zacharyburnett
force-pushed
the
minimum_dependencies
branch
from
ef1d089 to
5dccc20
Compare
WilliamJamieson
requested changes
Feb 16, 2023
Collaborator
WilliamJamieson
left a comment
WilliamJamieson
left a comment
There was a problem hiding this comment.
I think you need to remove this too:
Line 114 in 4a0c4c0
zacharyburnett
force-pushed
the
minimum_dependencies
branch
from
20113b1 to
4d874c3
Compare
WilliamJamieson
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses a common
minimum_dependenciespackage at https://github.com/spacetelescope/minimum_dependenciesChecklist for maintainers
CHANGES.rstwithin the relevant release sectionHow to run regression tests on a PR