Skip to content

Conversation

@zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Jan 30, 2023

This PR addresses the issue where MacOS artifacts have not been uploaded since October. The MacOS job was commented out because of an issue where sed was not available on boyle, which caused the regression tests to hang and fail. The sed issue has since been resolved.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@zacharyburnett zacharyburnett self-assigned this Jan 30, 2023
@github-actions github-actions bot added automation Continuous Integration (CI) and testing automation tools regression_testing labels Jan 30, 2023
@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 78.50% // Head: 78.50% // No change to project coverage 👍

Coverage data is based on head (2799353) compared to base (a467283).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #7445   +/-   ##
=======================================
  Coverage   78.50%   78.50%           
=======================================
  Files         455      455           
  Lines       39195    39195           
=======================================
  Hits        30771    30771           
  Misses       8424     8424           
Flag Coverage Δ
nightly 78.50% <ø> (ø)
unit 51.36% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zacharyburnett
Copy link
Collaborator Author

@zacharyburnett zacharyburnett marked this pull request as ready for review January 31, 2023 12:53
@zacharyburnett zacharyburnett enabled auto-merge (squash) January 31, 2023 12:56
@zacharyburnett zacharyburnett merged commit 23a8b6a into spacetelescope:master Jan 31, 2023
@zacharyburnett zacharyburnett deleted the reenable_macos branch January 31, 2023 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automation Continuous Integration (CI) and testing automation tools no-changelog-entry-needed regression_testing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants