Skip to content

Conversation

@hbushouse
Copy link
Collaborator

@hbushouse hbushouse commented Jan 5, 2023

This PR updates the existing MIRI LRS fixed-slit regression tests for spec2 and spec3 pipelines, and the LRS slitless tso1, tso-spec2, and tso3 tests, to use recent in-flight data. All new input and truth files have been uploaded to artifactory.

Checklist for maintainers

  • added entry in CHANGES.rst within the relevant release section
  • updated or added relevant tests
  • updated relevant documentation
  • added relevant milestone
  • added relevant label(s)
  • ran regression tests, post a link to the Jenkins job below.
    How to run regression tests on a PR
  • Make sure the JIRA ticket is resolved properly

@hbushouse
Copy link
Collaborator Author

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 78.49% // Head: 78.49% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (16d0fc7) compared to base (610a07a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #7424      +/-   ##
==========================================
- Coverage   78.49%   78.49%   -0.01%     
==========================================
  Files         455      455              
  Lines       39079    39143      +64     
==========================================
+ Hits        30677    30726      +49     
- Misses       8402     8417      +15     
Flag Coverage Δ
nightly 78.49% <ø> (+0.01%) ⬆️
unit 51.34% <ø> (+0.03%) ⬆️
Impacted Files Coverage Δ
jwst/white_light/white_light.py 89.13% <0.00%> (-4.35%) ⬇️
jwst/scripts/minimum_deps.py 24.00% <0.00%> (-1.00%) ⬇️
jwst/associations/asn_edit.py 66.66% <0.00%> (-0.75%) ⬇️
jwst/model_blender/blendmeta.py 83.05% <0.00%> (-0.71%) ⬇️
jwst/scripts/collect_pipeline_cfgs.py 13.33% <0.00%> (-0.46%) ⬇️
jwst/ami/lg_model.py 62.03% <0.00%> (-0.34%) ⬇️
jwst/refpix/irs2_subtract_reference.py 83.97% <0.00%> (-0.30%) ⬇️
jwst/ami/utils.py 87.96% <0.00%> (-0.29%) ⬇️
jwst/ami/nrm_core.py 20.61% <0.00%> (-0.28%) ⬇️
jwst/fits_generator/template.py 16.98% <0.00%> (-0.27%) ⬇️
... and 20 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hbushouse hbushouse changed the title Update MIRI LRS fixedslit regtests Update MIRI LRS regtests Jan 6, 2023
Copy link
Contributor

@tapastro tapastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and I double-checked that they aren't proprietary 👍

@hbushouse hbushouse merged commit d89abc0 into spacetelescope:master Jan 7, 2023
@hbushouse hbushouse deleted the regtest_lrs branch January 7, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants