Skip to content

Conversation

@jemorrison
Copy link
Collaborator

@drlaw1558
This should do it. I am checking on what the nightly regression test use for the CRDS context. Once we confirm it includes the new NIRSpec Cube pars reference file we will be able to merge this PR

@codecov
Copy link

codecov bot commented Aug 24, 2020

Codecov Report

Merging #5277 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5277   +/-   ##
=======================================
  Coverage   52.40%   52.40%           
=======================================
  Files         406      406           
  Lines       36480    36480           
  Branches     5645     5645           
=======================================
  Hits        19117    19117           
  Misses      16183    16183           
  Partials     1180     1180           
Flag Coverage Δ
#unit 52.40% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jwst/cube_build/cube_build_step.py 26.21% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02d64bc...0d79835. Read the comment docs.

@jemorrison
Copy link
Collaborator Author

@hbushouse or @stscieisenhamer
Ok for me to merge ?

@jemorrison jemorrison merged commit 740c85a into spacetelescope:master Aug 25, 2020
@jemorrison jemorrison deleted the JP-1653_cube_build_emsm branch September 14, 2020 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants