Fix NIRSPEC IFU slices problem in JP-932 #5047
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jemorrison
changed the title
Codecov Report
@@ Coverage Diff @@
## master #5047 +/- ##
==========================================
- Coverage 53.04% 53.04% -0.01%
==========================================
Files 401 401
Lines 35597 35601 +4
Branches 5518 5519 +1
==========================================
+ Hits 18883 18884 +1
- Misses 15576 15578 +2
- Partials 1138 1139 +1
Continue to review full report at Codecov.
|
hbushouse
requested review from
hbushouse and
stscirij
and removed request for
stscirij
hbushouse
reviewed
Jun 17, 2020
Collaborator
hbushouse
left a comment
hbushouse
left a comment
There was a problem hiding this comment.
Took me a bit of time to sort out the new logic in my head, but I think it looks OK.
Just need to add a change log entry.
Collaborator
Author
|
Yes it is ready to merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the NIRSPEC slices not mapping properly.
A fix was required in pathloss and photom to remove wavelengths with NANs
Resolves #3910 / JP-932