TST: Unleash isort (#9653)

Author: melanieclarke

.ruff.toml

@@ -29,6 +29,7 @@ select = [
     "ARG",    # flake8-unused-arguments (prevent unused arguments)
     "B",      # flake8-bugbear (miscellaneous best practices to avoid bugs)
     "C4",     # flake8-comprehensions (best practices for comprehensions)
+    "I",      # isort
     "ICN",    # flake8-import-conventions (enforce import conventions)
     "INP",    # flake8-no-pep420 (prevent use of PEP420, i.e. implicit name spaces)
     "ISC",    # flake8-implicit-str-concat (conventions for concatenating long strings)
@@ -139,3 +140,6 @@ ignore-fully-untyped = true  # Turn off annotation checking for fully untyped co
     "F841", # unused variable
     "S101",
 ]
+
+[lint.isort]
+known-first-party = ["jwst"]

jwst/__init__.py

@@ -1,7 +1,6 @@
 """Process JWST data with Python."""
 
 import re
-
 from importlib.metadata import version
 
 __version__ = version(__name__)

jwst/ami/ami_analyze.py

@@ -1,13 +1,12 @@
+import copy
 import logging
+
 import numpy as np
-import copy
 
 from jwst.datamodels import CubeModel, ImageModel  # type: ignore[attr-defined]
 
+from . import instrument_data, nrm_core, utils
 from .find_affine2d_parameters import find_rotation
-from . import instrument_data
-from . import nrm_core
-from . import utils
 
 log = logging.getLogger(__name__)
 log.setLevel(logging.DEBUG)

jwst/ami/ami_analyze_step.py

@@ -1,11 +1,10 @@
+import asdf
+import numpy as np
 from stdatamodels.jwst import datamodels
 
 from jwst.stpipe import Step
-from . import ami_analyze
-from . import utils
 
-import numpy as np
-import asdf
+from . import ami_analyze, utils
 
 __all__ = ["AmiAnalyzeStep"]
 

jwst/ami/ami_average_step.py

@@ -1,6 +1,8 @@
+import warnings
+
 from jwst.stpipe import Step
+
 from . import ami_average
-import warnings
 
 __all__ = ["AmiAverageStep"]
 

jwst/ami/ami_normalize.py

@@ -4,6 +4,7 @@
 #
 
 import logging
+
 from . import oifits
 
 log = logging.getLogger(__name__)

jwst/ami/analyticnrm2.py

@@ -4,11 +4,11 @@
 
 import logging
 import warnings
+
 import numpy as np
 import scipy.special
-from . import leastsqnrm
-from . import utils
-from . import hextransformee
+
+from . import hextransformee, leastsqnrm, utils
 
 log = logging.getLogger(__name__)
 log.addHandler(logging.NullHandler())

jwst/ami/bp_fix.py

@@ -1,15 +1,15 @@
 """Pipeline implementation of Jens Kammerer's bp_fix code based on Ireland 2013 algorithm."""
 
-import numpy as np
 import logging
 import warnings
-
 from copy import deepcopy
-from .matrix_dft import matrix_dft
-from scipy.ndimage import median_filter
 
+import numpy as np
+from scipy.ndimage import median_filter
 from stdatamodels.jwst.datamodels import dqflags
 
+from .matrix_dft import matrix_dft
+
 log = logging.getLogger(__name__)
 log.setLevel(logging.DEBUG)
 logging.captureWarnings(True)

jwst/ami/find_affine2d_parameters.py

@@ -1,8 +1,8 @@
 import logging
+
 import numpy as np
 
-from . import lg_model
-from . import utils
+from . import lg_model, utils
 
 log = logging.getLogger(__name__)
 log.setLevel(logging.DEBUG)

jwst/ami/instrument_data.py

@@ -1,12 +1,11 @@
+import copy
 import logging
-import numpy as np
 
-from .mask_definition_ami import NRMDefinition
-from . import utils
-from . import bp_fix
+import numpy as np
 from stdatamodels.jwst.datamodels import dqflags
-import copy
 
+from . import bp_fix, utils
+from .mask_definition_ami import NRMDefinition
 
 log = logging.getLogger(__name__)
 log.setLevel(logging.DEBUG)