-
Notifications
You must be signed in to change notification settings - Fork 180
TST: Unleash isort #9653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Unleash isort #9653
Conversation
64289bf to
7ef6297
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #9653 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 367 367
Lines 37313 37273 -40
=====================================
+ Misses 37313 37273 -40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
melanieclarke
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, and thank you - this is a huge maintainability improvement for my brain specifically.
I'll hold off on approval in case anyone else wants to weigh in.
emolter
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't really matter either way to me personally, but I see nothing wrong with it since it gets auto-fixed anyway
|
Well, that was fast. Thanks! 😸 |
This PR standardized how imports are sorted in all modules for ease of future maintenance by humans.
Tasks
Build 12.0(use the latest build if not sure)no-changelog-entry-needed)changes/:echo "changed something" > changes/<PR#>.<changetype>.rst(see changelog readme for instructions)docs/pageokify_regteststo update the truth files