Skip to content

Conversation

@pllim
Copy link
Collaborator

@pllim pllim commented Jul 15, 2025

This PR standardized how imports are sorted in all modules for ease of future maintenance by humans.

Tasks

@codecov
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

❌ Patch coverage is 0% with 318 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (16575e7) to head (f5f1546).
⚠️ Report is 418 commits behind head on main.

Files with missing lines Patch % Lines
jwst/cube_build/ifu_cube.py 0.00% 9 Missing ⚠️
jwst/lib/set_telescope_pointing.py 0.00% 9 Missing ⚠️
jwst/assign_wcs/niriss.py 0.00% 6 Missing ⚠️
jwst/assign_wcs/pointing.py 0.00% 6 Missing ⚠️
jwst/assign_wcs/util.py 0.00% 6 Missing ⚠️
jwst/associations/lib/rules_level3_base.py 0.00% 6 Missing ⚠️
jwst/datamodels/container.py 0.00% 6 Missing ⚠️
jwst/extract_1d/soss_extract/atoca_utils.py 0.00% 6 Missing ⚠️
jwst/extract_1d/soss_extract/soss_extract.py 0.00% 6 Missing ⚠️
jwst/assign_wcs/assign_wcs.py 0.00% 5 Missing ⚠️
... and 136 more
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #9653   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        367     367           
  Lines      37313   37273   -40     
=====================================
+ Misses     37313   37273   -40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pllim pllim marked this pull request as ready for review July 15, 2025 23:08
@pllim pllim requested review from a team as code owners July 15, 2025 23:08
@pllim pllim requested a review from melanieclarke July 15, 2025 23:09
Copy link
Collaborator

@melanieclarke melanieclarke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and thank you - this is a huge maintainability improvement for my brain specifically.

I'll hold off on approval in case anyone else wants to weigh in.

@melanieclarke melanieclarke requested a review from emolter July 16, 2025 13:09
Copy link
Collaborator

@emolter emolter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't really matter either way to me personally, but I see nothing wrong with it since it gets auto-fixed anyway

@melanieclarke melanieclarke enabled auto-merge July 16, 2025 13:33
@melanieclarke melanieclarke merged commit 9adccc6 into spacetelescope:main Jul 16, 2025
24 checks passed
@pllim pllim deleted the isort-usort-everyone-sort branch July 16, 2025 14:24
@pllim
Copy link
Collaborator Author

pllim commented Jul 16, 2025

Well, that was fast. Thanks! 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment