[WIP] Jdaviz integration #1658
Merged
[WIP] Jdaviz integration #1658
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…is potentially insecure
…se proxy requires it
bhilbert4
approved these changes
Jun 13, 2025
Collaborator
bhilbert4
left a comment
bhilbert4
left a comment
There was a problem hiding this comment.
Looks good. Just a few mostly-trivial comments. We've done enough testing that I'm confident things are working as expected.
mfixstsci
reviewed
Jun 16, 2025
mfixstsci
reviewed
Jun 16, 2025
mfixstsci
reviewed
Jun 16, 2025
Collaborator
Author
|
I've now pushed my first-pass response to the review. |
…ead of defined in every function that uses it
… into jdaviz_integration
mfixstsci
approved these changes
Jul 16, 2025
Collaborator
mfixstsci
left a comment
mfixstsci
left a comment
There was a problem hiding this comment.
Did virtual code review and all tasks are marked as completed. Here we go!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Jdaviz integration to the archived exposure pages, including both imaging and spectroscopic data. Note that Jdaviz is currently not perfectly optimized, so there may be long loading times in some cases. At this point, it isn't necessarily clear whether that will improve with further optimization.