Fix bad parens in dark monitor model definitions #1644
Merged
+764
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @bhilbert4, Thank you for updating ! Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated at 2024-08-30 15:25:21 UTC |
mfixstsci
approved these changes
Aug 30, 2024
Collaborator
mfixstsci
left a comment
mfixstsci
left a comment
There was a problem hiding this comment.
LGTM, tricky parenthesis 🙄
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small update to the dark monitor. Some of the model fields were redefined in #1493 but in the fields that were changed from text fields to arrays of charfields, the locations of the closing parentheses were wrong. This PR fixes those typos, and includes the resulting migration file.