Skip to content

Conversation

@mamhoff
Copy link
Contributor

@mamhoff mamhoff commented May 29, 2025

Summary

Prior to this commit, we had a before action populating the current_user_roles instance variable, and then we used that instance variable in helpers. This refactors it into an actual helper that we can then use as we need.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@mamhoff mamhoff requested a review from a team as a code owner May 29, 2025 09:47
@github-actions github-actions bot added the changelog:solidus_api Changes to the solidus_api gem label May 29, 2025
@tvdeyen tvdeyen added this to the 4.6 milestone May 29, 2025
@tvdeyen tvdeyen moved this to In Progress in Solidus Public Roadmap May 29, 2025
Prior to this commit, we had a before action populating the
`current_user_roles` instance variable, and then we used that instance
variable in helpers. This refactors it into an actual helper that we can
then use as we need.
@mamhoff mamhoff force-pushed the current-user-roles-helper branch from 038a1ea to 58e255c Compare May 30, 2025 08:14
@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 90.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.82%. Comparing base (0ba0738) to head (58e255c).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
api/app/controllers/spree/api/base_controller.rb 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6245      +/-   ##
==========================================
- Coverage   88.83%   88.82%   -0.01%     
==========================================
  Files         850      850              
  Lines       18329    18334       +5     
==========================================
+ Hits        16282    16286       +4     
- Misses       2047     2048       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen merged commit f0a7456 into solidusio:main May 30, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Solidus Public Roadmap May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_api Changes to the solidus_api gem

Projects

Development

Successfully merging this pull request may close these issues.

3 participants