Skip to content

Conversation

@benjaminwil
Copy link
Contributor

Summary

This pull request makes the order inventory cancellation and order cancellation emails send via the Solidus event system.

This brings those email processes in line with the existing order confirmation email and reimbursement email processes.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

@benjaminwil benjaminwil requested a review from a team as a code owner April 4, 2025 18:00
@github-actions github-actions bot added the changelog:solidus_core Changes to the solidus_core gem label Apr 4, 2025
@benjaminwil benjaminwil force-pushed the new-mailer-subscribers branch 3 times, most recently from 218e663 to 322c2ac Compare April 7, 2025 18:18
@benjaminwil
Copy link
Contributor Author

The failing CI runs don't appear to be related to these changes.

Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, love it! Keep those subscribers coming.

benjaminwil and others added 2 commits April 12, 2025 12:47
This makes the order cancellation mailer process more like the order
confirmation one.

Co-authored-by: Adam Mueller <[email protected]>
This makes the order inventory cancellation email process more like the
order confirmation email process.

Co-authored-by: Adam Mueller <[email protected]>
@benjaminwil benjaminwil force-pushed the new-mailer-subscribers branch from 322c2ac to 92fef52 Compare April 12, 2025 19:48
@benjaminwil
Copy link
Contributor Author

Rebased against main

@tvdeyen tvdeyen merged commit f4f129c into solidusio:main Apr 26, 2025
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants