Move OrderMailerSubscriber#send_confirmation_email #6199
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog:solidus_core
jarednorman
approved these changes
Mar 27, 2025
kennyadsl
approved these changes
Mar 28, 2025
We're moving towards having a separate subscriber for each type of transaction email. This commit ensures that `OrderMailerSubscriber` actions are all moved to subscriber classes that more accurately describe the mailer action being taken. Now, the old `OrderMailerSubscriber` does nothing and can be removed in the next version of Solidus. In subsequent commits we can now add additional subscribers for: - Carton shipped transactional emails - Short ship transactional emails - Order cancellation transactionals emails Co-authored-by: Senem Soy <[email protected]>
benjaminwil
force-pushed
the
order-confirmation-mailer-subscriber
branch
from
bb3a87d to
38a9d36
Compare
Contributor
Author
|
It does not look like the failing CI steps are related to this change. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We're moving towards having a separate subscriber for each type of transaction email. This commit ensures that
OrderMailerSubscriberactions are all moved to subscriber classes that more accurately describe the mailer action being taken.Now, the old
OrderMailerSubscriberdoes nothing and can be removed in the next version of Solidus.In subsequent commits we can now add additional subscribers for:
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs: