Skip to content

Conversation

@fthobe
Copy link
Contributor

@fthobe fthobe commented Feb 19, 2025

Concerns (but doesn't solve): #6112 #6110

Summary

This is the first in a series of PRs to achieve fiscal compliance with EU regulation on Solidus easier.
This dropdown, which will also be introduced on Addresses in the future allows to set a Store as reverse charge compliant, allowing to decide on a per store front level if reverse charge can be applied.

This can be especially useful if driving different stores with different legal entities.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@fthobe fthobe requested a review from a team as a code owner February 19, 2025 10:16
@github-actions github-actions bot added changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem labels Feb 19, 2025
@fthobe
Copy link
Contributor Author

fthobe commented Feb 19, 2025

@shahmayur001 We need to add the OpenAPI docs for this one.

@fthobe
Copy link
Contributor Author

fthobe commented Feb 19, 2025

@kennyadsl should be ok, only test failing is store credit being flaky on admin

@fthobe
Copy link
Contributor Author

fthobe commented Feb 22, 2025

@tvdeyen @kennyadsl Failing test doesn't seem to be related, can we merge this? It's a preparatory step for fixing the vat discussion and allows to either manually or via API determine reverse charge status when we also integrate the organisation fields from PR #6113 down the road.

@JustShah JustShah force-pushed the store-reverse-charge-status branch from 32fdfe1 to f087ad5 Compare February 26, 2025 09:12
@tvdeyen tvdeyen changed the title [Compliance] Store reverse charge status Store reverse charge status Mar 10, 2025
@tvdeyen tvdeyen changed the title Store reverse charge status Add reverse charge status to stores Mar 21, 2025
@JustShah JustShah force-pushed the store-reverse-charge-status branch from f087ad5 to 720e1dc Compare March 21, 2025 09:29
Store model now has an enum for reverse_charge_status which let's user choose
whether it is enabled, disabled or not validated.
Allows access to the reverse_charge_status attribute through existing store APIs.
@JustShah JustShah force-pushed the store-reverse-charge-status branch from 720e1dc to 02d297c Compare March 21, 2025 09:30
@codecov
Copy link

codecov bot commented Mar 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.61%. Comparing base (dfe87ae) to head (3351a85).
Report is 124 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6136      +/-   ##
==========================================
- Coverage   88.67%   86.61%   -2.07%     
==========================================
  Files         829      511     -318     
  Lines       17995    11802    -6193     
==========================================
- Hits        15957    10222    -5735     
+ Misses       2038     1580     -458     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@JustShah JustShah force-pushed the store-reverse-charge-status branch from 02d297c to 6b9384f Compare March 21, 2025 09:54
Updated the store form for reverese_charge_status
user can select the charge status from the dropdown for the store
@JustShah JustShah force-pushed the store-reverse-charge-status branch from 6b9384f to 3351a85 Compare March 21, 2025 09:57
Copy link
Member

@tvdeyen tvdeyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fthobe
Copy link
Contributor Author

fthobe commented Apr 9, 2025

@jarednorman @tvdeyen I inform you once more that even approved this is only a partial fix and a solution needs to be found

  • to handle taxed and untaxed prices for reverse charge

@tvdeyen tvdeyen merged commit 92431a9 into solidusio:main Apr 9, 2025
20 of 21 checks passed
@tvdeyen
Copy link
Member

tvdeyen commented Apr 9, 2025

to handle taxed and untaxed prices

This is a very broad statement. Solidus handles taxed and untaxed prices very well.

@fthobe
Copy link
Contributor Author

fthobe commented Apr 9, 2025

#6169

@fthobe
Copy link
Contributor Author

fthobe commented Apr 9, 2025

#6168

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog:solidus_api Changes to the solidus_api gem changelog:solidus_backend Changes to the solidus_backend gem changelog:solidus_core Changes to the solidus_core gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants