-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Add reverse charge status to stores #6136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add reverse charge status to stores #6136
Conversation
|
@shahmayur001 We need to add the OpenAPI docs for this one. |
|
@kennyadsl should be ok, only test failing is store credit being flaky on admin |
|
@tvdeyen @kennyadsl Failing test doesn't seem to be related, can we merge this? It's a preparatory step for fixing the vat discussion and allows to either manually or via API determine reverse charge status when we also integrate the organisation fields from PR #6113 down the road. |
32fdfe1 to
f087ad5
Compare
f087ad5 to
720e1dc
Compare
Store model now has an enum for reverse_charge_status which let's user choose whether it is enabled, disabled or not validated.
Allows access to the reverse_charge_status attribute through existing store APIs.
720e1dc to
02d297c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6136 +/- ##
==========================================
- Coverage 88.67% 86.61% -2.07%
==========================================
Files 829 511 -318
Lines 17995 11802 -6193
==========================================
- Hits 15957 10222 -5735
+ Misses 2038 1580 -458 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
02d297c to
6b9384f
Compare
Updated the store form for reverese_charge_status user can select the charge status from the dropdown for the store
6b9384f to
3351a85
Compare
tvdeyen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
@jarednorman @tvdeyen I inform you once more that even approved this is only a partial fix and a solution needs to be found
|
This is a very broad statement. Solidus handles taxed and untaxed prices very well. |
Concerns (but doesn't solve): #6112 #6110
Summary
This is the first in a series of PRs to achieve fiscal compliance with EU regulation on Solidus easier.
This dropdown, which will also be introduced on Addresses in the future allows to set a Store as reverse charge compliant, allowing to decide on a per store front level if reverse charge can be applied.
This can be especially useful if driving different stores with different legal entities.
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: