[v4.4] Add Ruby 3.4 support #6123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 3c2167a)
Since Ruby 3.4 the csv library is it's own gem (cherry picked from commit 169a012)
Ruby 3.4 finally adds the new has key syntax into inspect. Since we still support older Ruby versions we just remove the expectation of the hash key. (cherry picked from commit cc025c3)
github-actions
bot
added
changelog:solidus_core
Merged
4 tasks
tvdeyen
approved these changes
Feb 14, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v4.4 #6123 +/- ##
=======================================
Coverage 89.46% 89.46%
=======================================
Files 782 782
Lines 18005 18005
=======================================
Hits 16108 16108
Misses 1897 1897 ☔ View full report in Codecov by Sentry. |
kennyadsl
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maintov4.4:Questions ?
Please refer to the Backport tool documentation