Skip to content

Conversation

@tvdeyen
Copy link
Member

@tvdeyen tvdeyen commented Jan 9, 2025

Summary

Linting runs parallel to testing and circle ci is
slow and our free plan has limited resources.

Also GH actions are better integrated and has better dev feedback.

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

The following are not always needed:

  • 📖 I have updated the README to account for my changes.
  • 📑 I have documented new code with YARD.
  • 🛣️ I have opened a PR to update the guides.
  • ✅ I have added automated tests to cover my changes.
  • 📸 I have attached screenshots to demo visual changes.

@tvdeyen tvdeyen requested a review from a team as a code owner January 9, 2025 16:59
@github-actions github-actions bot added the changelog:repository Changes to the repository not within any gem label Jan 9, 2025
@tvdeyen tvdeyen requested a review from a team January 15, 2025 07:29
Copy link
Member

@kennyadsl kennyadsl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@tvdeyen tvdeyen mentioned this pull request Jan 15, 2025
Linting runs parallel to testing and circle ci is
slow and our free plan has limited resources.

Also GH actions are better integrated and has better dev
feedback.
@tvdeyen tvdeyen enabled auto-merge January 15, 2025 10:49
@tvdeyen tvdeyen merged commit 3675af2 into solidusio:main Jan 15, 2025
15 of 16 checks passed
@tvdeyen tvdeyen deleted the lint-on-gh branch January 15, 2025 11:09
@codecov
Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.58%. Comparing base (332ed17) to head (7275966).
Report is 262 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6064   +/-   ##
=======================================
  Coverage   89.58%   89.58%           
=======================================
  Files         801      801           
  Lines       18275    18275           
=======================================
  Hits        16371    16371           
  Misses       1904     1904           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tvdeyen tvdeyen added backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 backport-v4.4 Backport this pull-request to v4.4 labels Jan 15, 2025
@github-actions
Copy link

💔 Some backports could not be created

Status Branch Result
v4.1 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.1:
- Merge pull request #5459 from tvdeyen/revert-5367
v4.2 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.2:
- Run installer CI jobs for PR targeting Solidus 4.2+
- Merge pull request #5459 from tvdeyen/revert-5367
v4.3 Backport failed because of merge conflicts
v4.4

Manual backport

To create the backport manually run:

backport --pr 6064

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions
Copy link

💔 All backports failed

Status Branch Result
v4.1 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.1:
- Merge pull request #5459 from tvdeyen/revert-5367
v4.2 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.2:
- Run installer CI jobs for PR targeting Solidus 4.2+
- Merge pull request #5459 from tvdeyen/revert-5367
v4.3 Backport failed because of merge conflicts
v4.4 An unhandled error occurred. Please see the logs for details

Manual backport

To create the backport manually run:

backport --pr 6064

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions
Copy link

💔 All backports failed

Status Branch Result
v4.1 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.1:
- Merge pull request #5459 from tvdeyen/revert-5367
v4.2 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.2:
- Run installer CI jobs for PR targeting Solidus 4.2+
- Merge pull request #5459 from tvdeyen/revert-5367
v4.3 Backport failed because of merge conflicts
v4.4 An unhandled error occurred. Please see the logs for details

Manual backport

To create the backport manually run:

backport --pr 6064

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions
Copy link

💔 Some backports could not be created

Status Branch Result
v4.1 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.1:
- Merge pull request #5459 from tvdeyen/revert-5367
v4.2 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.2:
- Run installer CI jobs for PR targeting Solidus 4.2+
- Merge pull request #5459 from tvdeyen/revert-5367
v4.3 Backport failed because of merge conflicts
v4.4

Manual backport

To create the backport manually run:

backport --pr 6064

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@tvdeyen
Copy link
Member Author

tvdeyen commented Jan 15, 2025

💚 All backports created successfully

Status Branch Result
v4.3

Questions ?

Please refer to the Backport tool documentation

@tvdeyen tvdeyen added the backport-v4.5 Backport this pull-request to v4.5 label May 30, 2025
@github-actions
Copy link

💔 All backports failed

Status Branch Result
v4.1 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.1:
- Merge pull request #5459 from tvdeyen/revert-5367
v4.2 Backport failed because of merge conflicts

You might need to backport the following PRs to v4.2:
- Run installer CI jobs for PR targeting Solidus 4.2+
- Merge pull request #5459 from tvdeyen/revert-5367
v4.3 Backport failed because of merge conflicts
v4.4 Cherrypick failed because the selected commit (7275966) is empty. It looks like the commit was already backported in #6069
v4.5 Cherrypick failed because the selected commit (7275966) is empty. Did you already backport this commit?

Manual backport

To create the backport manually run:

backport --pr 6064

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@github-actions github-actions bot mentioned this pull request May 30, 2025
4 tasks
@tvdeyen tvdeyen removed backport-v4.1 Backport this pull-request to v4.1 backport-v4.2 Backport this pull-request to v4.2 backport-v4.3 Backport this pull-request to v4.3 labels May 30, 2025
@tvdeyen tvdeyen removed the backport-v4.4 Backport this pull-request to v4.4 label May 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-v4.5 Backport this pull-request to v4.5 changelog:repository Changes to the repository not within any gem

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants