Display the store's currency in the Admin Order Index Component #5929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5929 +/- ##
=======================================
Coverage 88.82% 88.82%
=======================================
Files 835 835
Lines 18149 18149
=======================================
Hits 16121 16121
Misses 2028 2028 ☔ View full report in Codecov by Sentry. |
Member
|
@magpieuk thanks for the contribution. Can you please post a screenshot of the issue to understand where this happen exactly? |
kennyadsl
changed the title
Contributor
Author
|
|
Contributor
Author
|
There is also another similar issue here: components/solidus_admin/orders/show/summary/component.html.erb Not sure when this component is displayed yet to verify though. |
tvdeyen
reviewed
Nov 18, 2024
Member
tvdeyen
left a comment
tvdeyen
left a comment
There was a problem hiding this comment.
Thanks. Can you add a test as well?
tvdeyen
force-pushed
the
solidus-order-index-fix
branch
from
f01bacb to
eb422d2
Compare
Member
|
@chaimann can you take this over please? |
Contributor
|
@tvdeyen sure! |
Admin order index page doesn't reflect the stores currency. Use "money_method" `:display_total` that handles correct formatting of the money values, taking into account order's currency.
chaimann
force-pushed
the
solidus-order-index-fix
branch
from
eb422d2 to
50ceba8
Compare
github-actions
bot
added
the
changelog:solidus_core
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Admin order index page doesn't reflect the stores currency.
Summary
Changed admin orders index page to use display_total rather than number_to_currency(order.total) this displays the correct currency for the order rather than defaulting to USD
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: