Make 0.0.0.0/0 and ::/0 not mean any address family, add any for that #1538
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnmaguire
previously approved these changes
Nov 21, 2025
Collaborator
johnmaguire
left a comment
johnmaguire
left a comment
There was a problem hiding this comment.
LGTM, and test coverage looks good.
| fr.Hosts[host] = nlc | ||
| } | ||
|
|
||
| if ip.IsValid() { |
Collaborator
There was a problem hiding this comment.
For future reviewers - this just tells you if it's a zero-value or not. This is not true validation per se. We won't return new errors we didn't return before for an "invalid" IP.
Collaborator
There was a problem hiding this comment.
https://pkg.go.dev/net/netip#Addr.IsValid strange they didn't follow the pattern in https://pkg.go.dev/time#Time.IsZero which is much more clear.
johnmaguire
approved these changes
Nov 21, 2025
JackDoan
approved these changes
Nov 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This scenario is only present on
mastersince v1.9.x and prior would refuse ipv6 traffic.Currently a cidr of
0.0.0.0/0or::/0results in a short circuitanyfor both ipv4 or ipv6 addresses. This is unnecessary and could lead to surprises for network operators.This change makes it so that
0.0.0.0/0means only all ipv4 addresses and::/0means only all ipv6 addresses.This also adds support for the special
cidr: anyandlocalCidr: anywhich actually means "any ip family and address". The main reason for this is in unsafe routes, when you desire to expose the entirelocalCidrnetworks. If we did not supportlocalCidr: anythen you would need to create 2 rules, one for ipv40.0.0.0/0and another for ip6::/0.