Docs: Added pushing properties to Readme #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sungam3r
reviewed
Oct 22, 2020
Co-authored-by: Ivan Maximov <[email protected]>
nblumhardt
reviewed
Oct 22, 2020
Member
nblumhardt
left a comment
nblumhardt
left a comment
There was a problem hiding this comment.
Just some nitpicky suggestions from me, looks good!
Contributor
Author
|
I’m ok with squashing this PR, because it looks like a mess right now. Four commits to change one alinea in the readme. Just squash and add this to the commit message:
|
Member
|
Thanks 👍 |
Contributor
Author
|
You're welcome |
Merged
This was referenced Mar 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #212