Adding source context for the logging in RequestLoggingMiddleware.

[adamlith]

Fixing Issue #123

[nblumhardt]

Thanks for the PR! Much appreciated 👍

Just realised that there's a decent opportunity to avoid an allocation here, what do you think?

Cheers!

[nblumhardt]

This will cause some additional allocations on every request; alternatively, we could create a:

static readonly LogEventProperty SourceContextProperty = new LogEventProperty("SourceContext", typeof(SerilogRequestLoggingMiddleware).FullName);

and then include this in the list of properties that are manually added to the event a few lines below?

[adamlith]

But do we not need to have set the source context for the IsEnabled check?

if (!logger.IsEnabled(level)) return false;

if not then I agree with you and I'll change it to your suggestion.

[nblumhardt]

Ah right you are, nicely spotted 😅

Would still be nice to trim some allocations down the track, but I think the change as written is good for now 👍

Very minor nitpick:

var logger = Log.Logger.ForContext<RequestLoggingMiddleware>();

It's usually idiomatically written as:

var logger = Log.ForContext<RequestLoggingMiddleware>();

[adamlith]

Alright, I've fixed the nitpick-issue 👍

[nblumhardt]

👍 great, thanks Adam!