Skip to content

Conversation

@glemaitre
Copy link
Member

Remove the possibility to pass position arguments after the end of the deprecation cycle.

@codecov
Copy link

codecov bot commented Dec 3, 2022

Codecov Report

Base: 96.30% // Head: 96.24% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (2526b83) compared to base (021bbdf).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #952      +/-   ##
==========================================
- Coverage   96.30%   96.24%   -0.07%     
==========================================
  Files          97       97              
  Lines        6337     6277      -60     
  Branches      911      874      -37     
==========================================
- Hits         6103     6041      -62     
  Misses        150      150              
- Partials       84       86       +2     
Impacted Files Coverage Δ
imblearn/combine/_smote_enn.py 100.00% <ø> (ø)
imblearn/combine/_smote_tomek.py 100.00% <ø> (ø)
imblearn/datasets/_imbalance.py 73.33% <ø> (-3.14%) ⬇️
imblearn/datasets/_zenodo.py 91.52% <ø> (-0.28%) ⬇️
imblearn/ensemble/_bagging.py 89.88% <ø> (-0.23%) ⬇️
imblearn/ensemble/_easy_ensemble.py 90.66% <ø> (-0.25%) ⬇️
imblearn/ensemble/_weight_boosting.py 82.78% <ø> (-0.28%) ⬇️
imblearn/ensemble/tests/test_bagging.py 98.29% <ø> (-0.01%) ⬇️
imblearn/keras/_generator.py 91.78% <ø> (-0.33%) ⬇️
imblearn/metrics/_classification.py 91.78% <ø> (-0.27%) ⬇️
... and 17 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@glemaitre glemaitre merged commit a9470dc into scikit-learn-contrib:master Dec 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant