Slight MSRV bump and lint fixing #192
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
The nightly version (2024-03-10) was chosen because newer 1.78 nightlies suffer from the bug fixed here. |
AzureMarker
approved these changes
Aug 15, 2024
FenrirWolf
approved these changes
Aug 15, 2024
| #![allow(non_camel_case_types)] | ||
| #![allow(non_snake_case)] | ||
| #![allow(clippy::all)] | ||
| #![allow(unexpected_cfgs)] // Read below why we necessate a check for rust_analyzer. |
Member
There was a problem hiding this comment.
I probably would have advocated for adding rust_analyzer specifically as a known cfg something like
[lints.rust.unexpected_cfgs]
check-cfg = ['cfg(rust_analyzer)']but not a big difference really.
I guess I'm surprised this isn't a well-known value but I guess it's rarer to set than many of those other ones
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An absolutely tiny PR to fix some annoying lints and to push the crate on a higher MSRV.