Use common variants for open and close delimiters #18430
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brendanzab
force-pushed
the
token
branch
3 times, most recently
from
dfbbb23 to
81a0142
Compare
This common representation for delimeters should make pattern matching easier. Having a separate `token::DelimToken` enum also allows us to enforce the invariant that the opening and closing delimiters must be the same in `ast::TtDelimited`, removing the need to ensure matched delimiters when working with token trees.
We can simplify these usages due to the new delimiter representation. `Parser::expect_open_delim` has been added for convenience.
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Oct 31, 2014
Conflicts: src/libsyntax/parse/parser.rs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This common representation for delimeters should make pattern matching easier. Having a separate
token::DelimTokenenum also allows us to enforce the invariant that the opening and closing delimiters must be the same inast::TtDelimited, removing the need to ensure matched delimiters when working with token trees, (for example, in gl-rs)