Skip to content

bump bootstrap compiler to 1.93 beta #149831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
BoxyUwU wants to merge 5 commits into
base: main
Choose a base branch
from
Open

bump bootstrap compiler to 1.93 beta #149831

BoxyUwU wants to merge 5 commits into from

Conversation

@BoxyUwU
Copy link
Member

@BoxyUwU BoxyUwU commented Dec 10, 2025

r? release

@rustbot
Copy link
Collaborator

rustbot commented Dec 10, 2025

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

The Miri subtree was changed

cc @rust-lang/miri

@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Dec 10, 2025
@BoxyUwU
Copy link
Member Author

BoxyUwU commented Dec 10, 2025

r? mark-simulacrum

@rustbot rustbot assigned Mark-Simulacrum and unassigned Dylan-DPC Dec 10, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
fmease
fmease reviewed Dec 10, 2025
View reviewed changes
@BoxyUwU @fmease
Update compiler/rustc_lint_defs/src/builtin.rs
8995537 
Co-authored-by: León Orell Valerian Liehr <[email protected]>
@jieyouxu jieyouxu mentioned this pull request Dec 10, 2025
Open
@Mark-Simulacrum
Copy link
Member

Mark-Simulacrum commented Dec 10, 2025

@bors r+

@bors
Copy link
Collaborator

bors commented Dec 10, 2025

📌 Commit 8995537 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 10, 2025
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Dec 10, 2025

@bors rollup=never

@jieyouxu
Copy link
Member

jieyouxu commented Dec 11, 2025

@bors p=5 (just to get the bootstrap compiler bump done)

@bors
Copy link
Collaborator

bors commented Dec 11, 2025

⌛ Testing commit 8995537 with merge 7eae21d...

bors added a commit that referenced this pull request Dec 11, 2025
@bors
Auto merge of #149831 - BoxyUwU:boostrap_bump, r=Mark-Simulacrum
7eae21d 
bump bootstrap compiler to 1.93 beta

r? release
@Zalathar
Copy link
Member

Zalathar commented Dec 11, 2025

@bors retry (timeout)

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2025
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Dec 11, 2025

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

bors added a commit that referenced this pull request Dec 11, 2025
@bors
Auto merge of #149831 - BoxyUwU:boostrap_bump, r=Mark-Simulacrum
d91eb8d 
bump bootstrap compiler to 1.93 beta

r? release
@bors
Copy link
Collaborator

bors commented Dec 11, 2025

⌛ Testing commit 8995537 with merge d91eb8d...

@bors bors mentioned this pull request Dec 11, 2025
Merged
@bors
Copy link
Collaborator

bors commented Dec 11, 2025

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 11, 2025
@rust-log-analyzer
Copy link
Collaborator

rust-log-analyzer commented Dec 11, 2025

A job failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@BoxyUwU
Copy link
Member Author

BoxyUwU commented Dec 11, 2025

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 11, 2025
bors added a commit that referenced this pull request Dec 11, 2025
@bors
Auto merge of #149831 - BoxyUwU:boostrap_bump, r=Mark-Simulacrum
c11d823 
bump bootstrap compiler to 1.93 beta

r? release
@bors
Copy link
Collaborator

bors commented Dec 11, 2025

⌛ Testing commit 8995537 with merge c11d823...

@Urgau
Copy link
Member

Urgau commented Dec 11, 2025

Seems like there is a hang when trying to run:

Running stage2 lint-docs (stage1 -> stage2, i686-pc-windows-msvc)

2025-12-11T12:27:37.2979959Z [TIMING:end] tool::LintDocs { compiler: Compiler { stage: 0, host: i686-pc-windows-msvc, forced_compiler: false }, target: i686-pc-windows-msvc } -- 0.000
2025-12-11T12:27:37.2998418Z ##[group]Running stage2 lint-docs (stage1 -> stage2, i686-pc-windows-msvc)
2025-12-11T16:18:05.0935989Z Entering debug mode. Use h or ? for help. 
2025-12-11T16:18:05.0941832Z 
2025-12-11T16:18:05.1067196Z At D:\a\rust\rust\x.ps1:20 char:5
2025-12-11T16:18:05.1067749Z +     Exit $LASTEXITCODE
2025-12-11T16:18:05.1068180Z +     ~~~~~~~~~~~~~~~~~~
2025-12-11T16:18:05.7138662Z [DBG]: PS D:\a\rust\rust>> 
2025-12-11T16:18:05.7835484Z ##[error]The operation was canceled.

@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Dec 11, 2025

Seems like it's stuck on the same thing again, probably better to just kill it?

@BoxyUwU
Copy link
Member Author

BoxyUwU commented Dec 11, 2025

crazy, spurriosu failuires are never non spurrious

@BoxyUwU
Copy link
Member Author

BoxyUwU commented Dec 11, 2025

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 11, 2025
@BoxyUwU
Copy link
Member Author

BoxyUwU commented Dec 11, 2025

can you even cancel a bors merge lol

@bors retry
?

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 11, 2025
@BoxyUwU BoxyUwU added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 11, 2025
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Dec 11, 2025

bors retry r- should work

@samueltardieu
Copy link
Member

samueltardieu commented Dec 11, 2025 •
edited
Loading

bors retry r- should work

Since you're talking about it, I've been wondering for quite some time what it's supposed to mean. r- removes approval, so retry should not even re-run since it's been unapproved, right?. Or does it mean "run again but remove approval afterwards in case it fails"?

From what I understand, "bors retry" retries a job with the existing r+, while "bors r-" withdraws any existing permission. What do I get wrong here?

@Urgau
Copy link
Member

Urgau commented Dec 11, 2025

Yes, but r- doesn't stop the PR from being tested if the testing had already started, that's what the retry part is for, it forces Bors to cancel the current workflow and pick the next one in the queue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmease fmease fmease left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.