-
Notifications
You must be signed in to change notification settings - Fork 145
Make user-specified cflags take precedence over cc-rs flags #232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
056a6ea to
4e9ce56
Compare
|
The nightly error is rust-lang/rust#136086, will be fixed by rust-lang/rust#136098. |
|
for posterity, the full error was (CI logs go away after about 3 months) |
|
note that i do not plan to silence the "search path" not found error, so that will eventually come back unless someone makes a convincing case why it shouldn't. |
4e9ce56 to
836acf7
Compare
|
Rebased, and filed rust-lang/libz-sys#235 to avoid the |
|
Hi! cmake-rs hasn't really been maintained in awhile but I'm trying to at least take a look at the open PRs. What is this status of this PR? Is it still wanted/needed? Is there any more context I should be aware of? |
|
I've kind of lost the context for this, but lemme try to recall: The flags that we import from This PR would make the ordering correct for the first case, but I think we'd still want environment variables like So the proper solution here is probably for |
When the user uses
.cflag/.cxxflag/.asmflag, we want those flags to take precedence over the default flags thatcc-rsadds.