Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions crates/cargo-test-support/src/compare.rs
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,7 @@ static E2E_LITERAL_REDACTIONS: &[(&str, &str)] = &[
("[BLOCKING]", " Blocking"),
("[GENERATED]", " Generated"),
("[OPENING]", " Opening"),
("[MERGING]", " Merging"),
];

/// Checks that the given string contains the given contiguous lines
Expand Down
2 changes: 2 additions & 0 deletions src/cargo/core/compiler/build_context/target_info.rs
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,8 @@ pub enum FileFlavor {
DebugInfo,
/// SBOM (Software Bill of Materials pre-cursor) file (e.g. cargo-sbon.json).
Sbom,
/// Cross-crate info JSON files generated by rustdoc.
DocParts,
}

/// Type of each file generated by a Unit.
Expand Down
28 changes: 26 additions & 2 deletions src/cargo/core/compiler/build_runner/compilation_files.rs
Original file line number Diff line number Diff line change
Expand Up @@ -275,6 +275,15 @@ impl<'a, 'gctx: 'a> CompilationFiles<'a, 'gctx> {
self.layout(unit.kind).build_dir().deps(&dir)
}

/// Returns the directories where Rust crate dependencies are found for the
/// specified unit. (new layout)
///
/// New features should consider using this so we can avoid their migrations.
pub fn deps_dir_new_layout(&self, unit: &Unit) -> PathBuf {
let dir = self.pkg_dir(unit);
self.layout(unit.kind).build_dir().deps_new_layout(&dir)
}

/// Directory where the fingerprint for the given unit should go.
pub fn fingerprint_dir(&self, unit: &Unit) -> PathBuf {
let dir = self.pkg_dir(unit);
Expand Down Expand Up @@ -495,12 +504,27 @@ impl<'a, 'gctx: 'a> CompilationFiles<'a, 'gctx> {
.join("index.html")
};

vec![OutputFile {
let mut outputs = vec![OutputFile {
path,
hardlink: None,
export_path: None,
flavor: FileFlavor::Normal,
}]
}];

if bcx.gctx.cli_unstable().rustdoc_mergeable_info {
// `-Zrustdoc-mergeable-info` always uses the new layout.
outputs.push(OutputFile {
path: self
.deps_dir_new_layout(unit)
.join(unit.target.crate_name())
.with_extension("json"),
hardlink: None,
export_path: None,
flavor: FileFlavor::DocParts,
})
}

outputs
}
CompileMode::RunCustomBuild => {
// At this time, this code path does not handle build script
Expand Down
61 changes: 57 additions & 4 deletions src/cargo/core/compiler/build_runner/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,15 +16,14 @@ use filetime::FileTime;
use itertools::Itertools;
use jobserver::Client;

use super::RustdocFingerprint;
use super::custom_build::{self, BuildDeps, BuildScriptOutputs, BuildScripts};
use super::fingerprint::{Checksum, Fingerprint};
use super::job_queue::JobQueue;
use super::layout::Layout;
use super::lto::Lto;
use super::unit_graph::UnitDep;
use super::{
BuildContext, Compilation, CompileKind, CompileMode, Executor, FileFlavor, RustDocFingerprint,
};
use super::{BuildContext, Compilation, CompileKind, CompileMode, Executor, FileFlavor};

mod compilation_files;
use self::compilation_files::CompilationFiles;
Expand Down Expand Up @@ -178,7 +177,7 @@ impl<'a, 'gctx> BuildRunner<'a, 'gctx> {
// they were compiled with the same Rustc version that we're currently using.
// See the function doc comment for more.
if self.bcx.build_config.intent.is_doc() {
RustDocFingerprint::check_rustdoc_fingerprint(&self)?
RustdocFingerprint::check_rustdoc_fingerprint(&self)?
}

for unit in &self.bcx.roots {
Expand Down Expand Up @@ -225,6 +224,8 @@ impl<'a, 'gctx> BuildRunner<'a, 'gctx> {
}
}

self.collect_doc_merge_info()?;

// Collect the result of the build into `self.compilation`.
for unit in &self.bcx.roots {
self.collect_tests_and_executables(unit)?;
Expand Down Expand Up @@ -330,6 +331,58 @@ impl<'a, 'gctx> BuildRunner<'a, 'gctx> {
Ok(())
}

fn collect_doc_merge_info(&mut self) -> CargoResult<()> {
if !self.bcx.gctx.cli_unstable().rustdoc_mergeable_info {
return Ok(());
}

if !self.bcx.build_config.intent.is_doc() {
return Ok(());
}

if self.bcx.build_config.intent.wants_doc_json_output() {
// rustdoc JSON output doesn't support merge (yet?)
return Ok(());
}

let mut doc_parts_map: HashMap<_, Vec<_>> = HashMap::new();

let unit_iter = if self.bcx.build_config.intent.wants_deps_docs() {
itertools::Either::Left(self.bcx.unit_graph.keys())
} else {
itertools::Either::Right(self.bcx.roots.iter())
};

for unit in unit_iter {
if !unit.mode.is_doc() {
continue;
}
// Assumption: one `rustdoc` call generates only one cross-crate info JSON.
let outputs = self.outputs(unit)?;

let Some(doc_parts) = outputs
.iter()
.find(|o| matches!(o.flavor, FileFlavor::DocParts))
else {
continue;
};

doc_parts_map
.entry(unit.kind)
.or_default()
.push(doc_parts.path.to_owned());
}

self.compilation.rustdoc_fingerprints = Some(
doc_parts_map
.into_iter()
.map(|(kind, doc_parts)| (kind, RustdocFingerprint::new(self, kind, doc_parts)))
.collect(),
);

Ok(())
}

/// Returns the executable for the specified unit (if any).
pub fn get_executable(&mut self, unit: &Unit) -> CargoResult<Option<PathBuf>> {
let is_binary = unit.target.is_executable();
Expand Down
7 changes: 7 additions & 0 deletions src/cargo/core/compiler/compilation.rs
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ use cargo_util::{ProcessBuilder, paths};

use crate::core::Package;
use crate::core::compiler::BuildContext;
use crate::core::compiler::RustdocFingerprint;
use crate::core::compiler::apply_env_config;
use crate::core::compiler::{CompileKind, Unit, UnitHash};
use crate::util::{CargoResult, GlobalContext, context};
Expand Down Expand Up @@ -106,6 +107,11 @@ pub struct Compilation<'gctx> {
/// Libraries to test with rustdoc.
pub to_doc_test: Vec<Doctest>,

/// Rustdoc fingerprint files to determine whether we need to run `rustdoc --merge=finalize`.
///
/// See `-Zrustdoc-mergeable-info` for more.
pub rustdoc_fingerprints: Option<HashMap<CompileKind, RustdocFingerprint>>,

/// The target host triple.
pub host: String,

Expand Down Expand Up @@ -143,6 +149,7 @@ impl<'gctx> Compilation<'gctx> {
root_crate_names: Vec::new(),
extra_env: HashMap::new(),
to_doc_test: Vec::new(),
rustdoc_fingerprints: None,
gctx: bcx.gctx,
host: bcx.host_triple().to_string(),
rustc_process,
Expand Down
2 changes: 1 addition & 1 deletion src/cargo/core/compiler/fingerprint/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,7 @@ pub use self::dep_info::parse_dep_info;
pub use self::dep_info::parse_rustc_dep_info;
pub use self::dep_info::translate_dep_info;
pub use self::dirty_reason::DirtyReason;
pub use self::rustdoc::RustDocFingerprint;
pub use self::rustdoc::RustdocFingerprint;

/// Determines if a [`Unit`] is up-to-date, and if not prepares necessary work to
/// update the persisted fingerprint.
Expand Down
Loading