Skip to content

Conversation

@rafegoldberg
Copy link
Contributor

@rafegoldberg rafegoldberg commented Apr 5, 2023

📖 PR App 🎫 Fix CX-217

🧰 Changes

SVGs weren't displaying at all when shown in the lightbox. (For example, try clicking on the first image here.)

  • override dimensions for lightboxed SVG images

🧬 QA & Testing

🚧 Note: we'll need to cut a new release and merge this in to ReadMe to fully test.

@rafegoldberg rafegoldberg added bug Something isn't working styles Changes related to visual styling labels Apr 5, 2023
@rafegoldberg rafegoldberg requested review from a team, kellyjosephprice, mosesj-readme and thenaomiday and removed request for a team April 5, 2023 10:32
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

A review app has been launched for this PR!

🔍 Inspect the app: https://dashboard.heroku.com/apps/markdown-pr-734

🧭 Take it for a spin: https://markdown-pr-734.herokuapp.com/

  • Shut down on Mon Apr 10: Since this PR is closed, its review app has been cleaned up. 🧽

@rafegoldberg rafegoldberg merged commit 71fc4e5 into next Apr 10, 2023
@rafegoldberg rafegoldberg deleted the fix/image/svg-dimensions-in-lightbox branch April 10, 2023 16:46
rafegoldberg pushed a commit that referenced this pull request Apr 14, 2023
## Version 6.61.1

### 🛠 Fixes & Updates

* centering in firefox ([#721](#721)) ([6a62281](6a62281))
* **image:** force SVG dimensions in lightbox ([#734](#734)) ([71fc4e5](71fc4e5))

<!--SKIP CI-->
@rafegoldberg
Copy link
Contributor Author

This PR was released!

🚀 Changes included in v6.61.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working released styles Changes related to visual styling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants