Initial translation of renderToPipeableStream page #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
mhaidarhanif
requested changes
Apr 30, 2023
src/content/reference/react-dom/server/renderToPipeableStream.md
Outdated
Show resolved
Hide resolved
mazipan
reviewed
May 1, 2023
src/content/reference/react-dom/server/renderToPipeableStream.md
Outdated
Show resolved
Hide resolved
mazipan
reviewed
May 1, 2023
src/content/reference/react-dom/server/renderToPipeableStream.md
Outdated
Show resolved
Hide resolved
Co-authored-by: M Haidar Hanif <[email protected]>
Co-authored-by: Irfan Maulana <[email protected]>
Co-authored-by: Irfan Maulana <[email protected]>
mhaidarhanif
approved these changes
Jun 4, 2023
mhaidarhanif
reviewed
Jun 4, 2023
Collaborator
mhaidarhanif
left a comment
mhaidarhanif
left a comment
There was a problem hiding this comment.
Need some improvements and italice most English words.
This is a comment, no request for changes to avoid future blocking.
src/content/reference/react-dom/server/renderToPipeableStream.md
Outdated
Show resolved
Hide resolved
src/content/reference/react-dom/server/renderToPipeableStream.md
Outdated
Show resolved
Hide resolved
src/content/reference/react-dom/server/renderToPipeableStream.md
Outdated
Show resolved
Hide resolved
src/content/reference/react-dom/server/renderToPipeableStream.md
Outdated
Show resolved
Hide resolved
src/content/reference/react-dom/server/renderToPipeableStream.md
Outdated
Show resolved
Hide resolved
Collaborator
|
@zaynhakim Please fix and resolve most issues. So we can merge this soon. |
mhaidarhanif
requested changes
Jun 5, 2023
Collaborator
mhaidarhanif
left a comment
mhaidarhanif
left a comment
There was a problem hiding this comment.
Please italice most English words like what I've mentioned. It's not just a few of them, but several of them.
src/content/reference/react-dom/server/renderToPipeableStream.md
Outdated
Show resolved
Hide resolved
src/content/reference/react-dom/server/renderToPipeableStream.md
Outdated
Show resolved
Hide resolved
src/content/reference/react-dom/server/renderToPipeableStream.md
Outdated
Show resolved
Hide resolved
src/content/reference/react-dom/server/renderToPipeableStream.md
Outdated
Show resolved
Hide resolved
src/content/reference/react-dom/server/renderToPipeableStream.md
Outdated
Show resolved
Hide resolved
src/content/reference/react-dom/server/renderToPipeableStream.md
Outdated
Show resolved
Hide resolved
src/content/reference/react-dom/server/renderToPipeableStream.md
Outdated
Show resolved
Hide resolved
src/content/reference/react-dom/server/renderToPipeableStream.md
Outdated
Show resolved
Hide resolved
src/content/reference/react-dom/server/renderToPipeableStream.md
Outdated
Show resolved
Hide resolved
src/content/reference/react-dom/server/renderToPipeableStream.md
Outdated
Show resolved
Hide resolved
Collaborator
|
Since turns out there are 20+ issues, I've requested the changes and now might block merging before they're resolved. |
Contributor
Author
|
Hi, thanks for the feedback. Going to reread it comprehensively. |
Collaborator
|
Fix the conflict first |
Contributor
Author
|
Done, resolved |
Collaborator
|
@mhaidarhanif help to re-review |
mazipan
approved these changes
Jun 6, 2023
mhaidarhanif
approved these changes
Jun 6, 2023
Collaborator
mhaidarhanif
left a comment
mhaidarhanif
left a comment
There was a problem hiding this comment.
Alright seems good. Let's merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #458