docs: react-dom/client: Client APIs translation
#485
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milhamm
changed the title
react-dom/client translation (wip)react-dom/client: Client APIs translation
milhamm
force-pushed
the
docs/translate-react-dom-client
branch
from
1523d1a to
06e22bb
Compare
Contributor
Author
|
Ready for review @resir014 @r17x @mhaidarhanif |
milhamm
force-pushed
the
docs/translate-react-dom-client
branch
from
30a236a to
8152d70
Compare
Size changes📦 Next.js Bundle Analysis for react-devThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
milhamm
force-pushed
the
docs/translate-react-dom-client
branch
from
ba05703 to
4fb966b
Compare
milhamm
force-pushed
the
docs/translate-react-dom-client
branch
from
4fb966b to
06cdd57
Compare
Collaborator
|
Should be fine but let's wait for the others. @resir014 @r17x @mazipan @zainfathoni |
mhaidarhanif
approved these changes
Apr 30, 2023
zainfathoni
requested changes
May 1, 2023
resir014
approved these changes
May 1, 2023
Member
resir014
left a comment
resir014
left a comment
There was a problem hiding this comment.
Should be good after implementing @zainfathoni's requested changes.
Contributor
Author
|
Updated |
Signed-off-by: Muhammad Ilham Mubarak <[email protected]>
Co-authored-by: Zain Fathoni <[email protected]>
milhamm
force-pushed
the
docs/translate-react-dom-client
branch
from
cd67c7b to
bcd35cd
Compare
r17x
approved these changes
May 1, 2023
Collaborator
|
Need @zainfathoni confirm before it merge |
zainfathoni
requested changes
May 1, 2023
Collaborator
zainfathoni
left a comment
zainfathoni
left a comment
There was a problem hiding this comment.
Sorry for these additional suggestions. I just caught them when reviewing this PR for the second time. 😅 🙏
mazipan
approved these changes
May 1, 2023
Collaborator
|
Okay @zainfathoni can approve and merge |
zainfathoni
approved these changes
May 1, 2023
Collaborator
zainfathoni
left a comment
zainfathoni
left a comment
There was a problem hiding this comment.
LGTM 💯
Let's ship it! 🚢
r17x
pushed a commit
that referenced
this pull request
May 8, 2023
Signed-off-by: Muhammad Ilham Mubarak <[email protected]> Co-authored-by: Zain Fathoni <[email protected]> Co-authored-by: Zain Fathoni <[email protected]> Co-authored-by: M Haidar Hanif <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translate
react-dom/client: Client APIspageStatus: Ready for proofreading
Closes #453