Skip to content

Conversation

@r17x
Copy link
Collaborator

@r17x r17x commented Apr 26, 2023

Translation for page https://id.react.dev/reference/react/lazy

Closes #471

@r17x r17x force-pushed the docs/translation/apis-lazy branch from 09c5e6e to b9f38b9 Compare April 26, 2023 12:43
@r17x r17x changed the title translations for APIs references lazy translations for APIs reference lazy Apr 26, 2023
Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some required changes:

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@resir014 resir014 linked an issue Apr 28, 2023 that may be closed by this pull request
@r17x
Copy link
Collaborator Author

r17x commented Apr 28, 2023

Need review from you @resir014

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Collaborator

@mhaidarhanif mhaidarhanif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good. @resir014 can confirm.

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@mhaidarhanif
Copy link
Collaborator

Okay let's wait again for @resir014

Copy link
Member

@resir014 resir014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r17x some suggested changes according to #337 (comment)

@r17x r17x force-pushed the docs/translation/apis-lazy branch from 893c066 to f7e7656 Compare May 1, 2023 09:09
@r17x r17x requested a review from resir014 May 1, 2023 09:09
@r17x
Copy link
Collaborator Author

r17x commented May 1, 2023

Updated @resir014

Copy link
Collaborator

@mazipan mazipan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@r17x
Copy link
Collaborator Author

r17x commented May 2, 2023

Need review @resir014

@resir014 resir014 changed the title translations for APIs reference lazy docs: translate API Reference > APIs > lazy May 3, 2023
@resir014 resir014 merged commit 9564a56 into reactjs:main May 3, 2023
r17x added a commit that referenced this pull request May 8, 2023
Co-authored-by: Resi Respati <[email protected]>
Co-authored-by: M Haidar Hanif <[email protected]>
Co-authored-by: Irfan Maulana <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

lazy

4 participants