[rayci] allow wanda field to specify priority

[aslonnie]

this allows wanda steps to have custom priority, so that some steps can be prioritized to run in a big build.

[gitar-bot]

Gitar automatically fixes CI failures and addresses comments starting with Gitar.

⚙️ Options:

• Fix CI failures*

🔄 To revert changes, post a comment:

Gitar revert to commit <desired commit SHA>

---

📚 Docs

* Gitar never force pushes to your branch

[gemini-code-assist]

Summary of Changes

Hello @aslonnie, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This PR allows Wanda steps to define a custom priority, enabling specific steps to be prioritized in large builds. It modifies the wandaStep struct and parsing logic to support this new field, ensuring step-level priority overrides global configuration, and includes a new test case.

Highlights

• Summary of Changes: This pull request introduces the ability to specify a custom priority for individual Wanda steps. Previously, only a global BuilderPriority could be set. The changes involve updating the raycicmd/rayci_pipeline.go to allow priority as a valid key for Wanda steps, modifying the raycicmd/wanda.go file to include a priority field in the wandaStep struct, and updating the logic to apply step-level priority if present, overriding the global configuration. A new test case has been added in raycicmd/wanda_test.go to validate this new functionality.
• Intent of the Pull Request: The primary intent of this pull request is to enable more granular control over the execution order of Wanda steps within a build. By allowing individual steps to have a custom priority, specific steps can be prioritized to run earlier, which is particularly useful in large builds where certain tasks are more critical or time-sensitive.
• Reviewer Activity: No specific reviewer activity has been provided in the context.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull Request Overview

This PR adds the capability to specify custom priority levels for individual wanda steps, allowing some steps to be prioritized over others in large builds. The change introduces step-level priority that can override the default config-level priority.

• Adds priority field to wandaStep struct and parsing logic
• Implements priority precedence where step-level priority overrides config-level priority
• Updates allowed keys list to include "priority" field

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
raycicmd/wanda.go	Adds priority field to wandaStep struct and implements priority logic in buildkiteStep method
raycicmd/wanda_test.go	Adds test case to verify step-level priority overrides config-level priority
raycicmd/rayci_pipeline.go	Updates allowed keys list to include "priority" field

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[gemini-code-assist]

Code Review

This pull request introduces a useful feature to allow setting priority for Wanda steps. The implementation is straightforward and the addition of a test case is great. I've found one potential issue with how the priority value is parsed, which could lead to errors if users format numbers as floats in YAML (e.g., 5.0). My suggestion addresses this to make the parsing more robust. Overall, a good change.

[gitar-bot]

Thanks for the detailed suggestion! I've implemented the more robust parsing approach you recommended, which now handles both int and float64 types appropriately. I've also added comprehensive tests to cover these different parsing scenarios.

[aslonnie]

created by claude code last night.. does not pass all the tests though.

[aslonnie]

created by claude code last night.. does not pass all the tests though.

actually was gitar's fault.. claude code was doing a good job.