Fix racecheck in the gpu_debrotli_kernel #20806
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes a racecheck reported by compute-sanitizer in the
gpu_debrotli_kernelcode found by theCOMPRESSION_TESTBrotliDecompressTest/BrotliDecompressTest.HelloWorld/0gtest:The
s->curvariable is read by all threads but may be set by thread 0 in a race condition.Adding a
__syncthreads()right after thes->curis read ensures it is not reset by any threads before all threads in the block have read it.Checklist