Fix: serialize writes to containerd to prevent locking errors #54
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When pushing images to a remote host, especially with newer versions of containerd (e.g., v2.0+ or Docker 27+), concurrent writes to the containerd content store can result in locking errors. Users may see errors like:
'rpc error: code = Unavailable desc = ref ... locked'
This commit introduces a mutex to serialize all write operations to the containerd writer. To maintain performance, 'ReadFrom' is implemented manually to perform network reads outside the lock, ensuring that data transfer remains parallel while the final write to disk/containerd is serialized. This prevents the locking contention while keeping upload speeds high.
Related container issues:
containerd error log I saw: