feat: Allow to match containers against truncated ID #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psviderski
approved these changes
Oct 28, 2025
| if c.Container.ID == containerNameOrID || c.Container.Name == containerNameOrID { | ||
| if c.Container.ID == containerNameOrID || | ||
| c.Container.Name == containerNameOrID || | ||
| stringid.TruncateID(c.Container.ID) == containerNameOrID { |
Owner
There was a problem hiding this comment.
This looks good but we can go even further and support any ID prefix as docker does. Something like
strings.HasPrefix(c.Container.ID, containerNameOrID)But in this case we shouldn't return right after the first match but instead compare the prefix against all containers. And return only if the prefix matches only one unique container.
Then a user will be able to type just a few first chars of the container id uc exec app --container ea0
It's up to you if you want to implement this right away. Otherwise supporting only 12-chars short IDs is fine as well.
Collaborator
Author
There was a problem hiding this comment.
Sounds good, added a TODO for that. Will need to think a bit more about edge cases, like a container's name being a prefix for some container id, or similar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@psviderski thoughts on this? Lmk if there was no intention to do any "smarter" kind of matching on this API level.
This would slightly simplify it for #139 (since people will only have access to the short ID and that's what they'll be pasting to
exec --container, but no big deal to write a small wrapper there.Alternatively: I can add another function like InspectContainerFuzzy or similar.