Skip to content

Backport some v11 optimizations #4967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JoviDeCroock merged 4 commits into from
Nov 29, 2025
Merged

Backport some v11 optimizations #4967

JoviDeCroock merged 4 commits into from
Nov 29, 2025
+3 −8

Conversation

@JoviDeCroock
Copy link
Member

@JoviDeCroock JoviDeCroock commented Nov 29, 2025

No description provided.

ali-garajian and others added 4 commits November 29, 2025 09:59
@ali-garajian @JoviDeCroock
refactor(children): remove redundant assignment to childVNode (#4951)
7a5570d 
* refactor(children): remove redundant assignment to childVNode

* refactor(children): use key instead of childVNode.key

---------

Co-authored-by: Ali Garajian <[email protected]>
@ali-garajian @JoviDeCroock
refactor(diff): no need to reset props and context when creating comp…
f5ab892 
…onent (#4954)

* refactor(children): remove redundant assignment to childVNode

* refactor(children): use key instead of childVNode.key

* refactor(diff): no need to reset props and context when creating component

---------

Co-authored-by: Ali Garajian <[email protected]>
@ali-garajian @JoviDeCroock
refactor(children): remove redundant assignment to oldVNode (#4956)
e06f8a5 
Co-authored-by: Ali Garajian <[email protected]>
@ali-garajian @JoviDeCroock
refactor(diff): set oldProps default value on declaration (#4959)
d3b72c9
@github-actions
Copy link

github-actions bot commented Nov 29, 2025 •
edited
Loading

📊 Tachometer Benchmark Results

Summary

duration

  • create10k: unsure 🔍 -1% - +1% (-5.82ms - +11.65ms)
    preact-local vs preact-main
  • filter-list: unsure 🔍 -1% - +1% (-0.15ms - +0.10ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -1% - +1% (-0.69ms - +0.94ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -1% - +0% (-0.18ms - +0.04ms)
    preact-local vs preact-main
  • replace1k: slower ❌ 0% - 4% (0.19ms - 2.49ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -7% - +1% (-0.13ms - +0.01ms)
    preact-local vs preact-main
  • todo: slower ❌ 0% - 2% (0.05ms - 0.63ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -3% - +3% (-0.78ms - +0.77ms)
    preact-local vs preact-main

usedJSHeapSize

  • create10k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • filter-list: faster ✔ 0% - 1% (0.00ms - 0.01ms)
    preact-local vs preact-main
  • hydrate1k: unsure 🔍 -5% - +5% (-0.33ms - +0.35ms)
    preact-local vs preact-main
  • many-updates: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • replace1k: unsure 🔍 -0% - +0% (-0.00ms - +0.00ms)
    preact-local vs preact-main
  • text-update: unsure 🔍 -1% - +6% (-0.01ms - +0.06ms)
    preact-local vs preact-main
  • todo: unsure 🔍 +0% - +0% (+0.00ms - +0.01ms)
    preact-local vs preact-main
  • update10th1k: unsure 🔍 -0% - +0% (-0.01ms - +0.00ms)
    preact-local vs preact-main

Results

create10k

duration

VersionAvg timevs preact-localvs preact-main
preact-local997.19ms - 1008.07ms-unsure 🔍
-1% - +1%
-5.82ms - +11.65ms
preact-main992.88ms - 1006.54msunsure 🔍
-1% - +1%
-11.65ms - +5.82ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local19.19ms - 19.19ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main19.19ms - 19.19msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
filter-list

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.57ms - 16.65ms-unsure 🔍
-1% - +1%
-0.15ms - +0.10ms
preact-main16.51ms - 16.75msunsure 🔍
-1% - +1%
-0.10ms - +0.15ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.55ms - 1.56ms-faster ✔
0% - 1%
0.00ms - 0.01ms
preact-main1.56ms - 1.56msslower ❌
0% - 1%
0.00ms - 0.01ms		-
hydrate1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local69.76ms - 71.00ms-unsure 🔍
-1% - +1%
-0.69ms - +0.94ms
preact-main69.73ms - 70.78msunsure 🔍
-1% - +1%
-0.94ms - +0.69ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local7.08ms - 7.53ms-unsure 🔍
-5% - +5%
-0.33ms - +0.35ms
preact-main7.04ms - 7.55msunsure 🔍
-5% - +5%
-0.35ms - +0.33ms		-
many-updates

duration

VersionAvg timevs preact-localvs preact-main
preact-local16.50ms - 16.55ms-unsure 🔍
-1% - +0%
-0.18ms - +0.04ms
preact-main16.49ms - 16.70msunsure 🔍
-0% - +1%
-0.04ms - +0.18ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.72ms - 3.72ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.72ms - 3.72msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-
replace1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local66.28ms - 67.93ms-slower ❌
0% - 4%
0.19ms - 2.49ms
preact-main64.97ms - 66.56msfaster ✔
0% - 4%
0.19ms - 2.49ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local3.00ms - 3.00ms-unsure 🔍
-0% - +0%
-0.00ms - +0.00ms
preact-main3.00ms - 3.00msunsure 🔍
-0% - +0%
-0.00ms - +0.00ms		-

run-warmup-0

VersionAvg timevs preact-localvs preact-main
preact-local26.96ms - 27.72ms-unsure 🔍
-2% - +2%
-0.62ms - +0.46ms
preact-main27.03ms - 27.81msunsure 🔍
-2% - +2%
-0.46ms - +0.62ms		-

run-warmup-1

VersionAvg timevs preact-localvs preact-main
preact-local34.06ms - 35.27ms-unsure 🔍
-4% - +2%
-1.24ms - +0.53ms
preact-main34.37ms - 35.66msunsure 🔍
-2% - +4%
-0.53ms - +1.24ms		-

run-warmup-2

VersionAvg timevs preact-localvs preact-main
preact-local34.39ms - 35.61ms-unsure 🔍
-2% - +3%
-0.63ms - +1.04ms
preact-main34.23ms - 35.36msunsure 🔍
-3% - +2%
-1.04ms - +0.63ms		-

run-warmup-3

VersionAvg timevs preact-localvs preact-main
preact-local27.14ms - 27.59ms-unsure 🔍
-1% - +1%
-0.31ms - +0.28ms
preact-main27.18ms - 27.57msunsure 🔍
-1% - +1%
-0.28ms - +0.31ms		-

run-warmup-4

VersionAvg timevs preact-localvs preact-main
preact-local26.45ms - 28.11ms-unsure 🔍
-5% - +4%
-1.29ms - +1.04ms
preact-main26.60ms - 28.23msunsure 🔍
-4% - +5%
-1.04ms - +1.29ms		-

run-final

VersionAvg timevs preact-localvs preact-main
preact-local22.37ms - 22.91ms-unsure 🔍
-0% - +3%
-0.10ms - +0.65ms
preact-main22.11ms - 22.62msunsure 🔍
-3% - +0%
-0.65ms - +0.10ms		-
text-update
  • Browser: chrome-headless
  • Sample size: 230
  • Built by: CI #5231

  • Commit: d3b72c9

duration

VersionAvg timevs preact-localvs preact-main
preact-local1.83ms - 1.94ms-unsure 🔍
-7% - +1%
-0.13ms - +0.01ms
preact-main1.89ms - 1.99msunsure 🔍
-1% - +7%
-0.01ms - +0.13ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.02ms - 1.07ms-unsure 🔍
-1% - +6%
-0.01ms - +0.06ms
preact-main1.00ms - 1.04msunsure 🔍
-6% - +1%
-0.06ms - +0.01ms		-
todo

duration

VersionAvg timevs preact-localvs preact-main
preact-local32.92ms - 33.43ms-slower ❌
0% - 2%
0.05ms - 0.63ms
preact-main32.71ms - 32.97msfaster ✔
0% - 2%
0.05ms - 0.63ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local1.26ms - 1.26ms-unsure 🔍
+0% - +0%
+0.00ms - +0.01ms
preact-main1.26ms - 1.26msunsure 🔍
-0% - -0%
-0.01ms - -0.00ms		-
update10th1k

duration

VersionAvg timevs preact-localvs preact-main
preact-local29.71ms - 30.86ms-unsure 🔍
-3% - +3%
-0.78ms - +0.77ms
preact-main29.77ms - 30.82msunsure 🔍
-3% - +3%
-0.77ms - +0.78ms		-

usedJSHeapSize

VersionAvg timevs preact-localvs preact-main
preact-local2.96ms - 2.96ms-unsure 🔍
-0% - +0%
-0.01ms - +0.00ms
preact-main2.96ms - 2.96msunsure 🔍
-0% - +0%
-0.00ms - +0.01ms		-

tachometer-reporter-action v2 for CI

@github-actions
Copy link

github-actions bot commented Nov 29, 2025

Size Change: -55 B (-0.07%)

Total Size: 79.1 kB

Filename Size Change
dist/preact.js 4.77 kB -11 B (-0.23%)
dist/preact.min.js 4.79 kB -6 B (-0.12%)
dist/preact.min.module.js 4.79 kB -9 B (-0.19%)
dist/preact.min.umd.js 4.82 kB -6 B (-0.12%)
dist/preact.mjs 4.78 kB -8 B (-0.17%)
dist/preact.module.js 4.78 kB -8 B (-0.17%)
dist/preact.umd.js 4.82 kB -7 B (-0.14%)
ℹ️ View Unchanged
Filename Size
compat/dist/compat.js 4.17 kB
compat/dist/compat.mjs 4.1 kB
compat/dist/compat.module.js 4.1 kB
compat/dist/compat.umd.js 4.24 kB
debug/dist/debug.js 3.85 kB
debug/dist/debug.mjs 3.85 kB
debug/dist/debug.module.js 3.85 kB
debug/dist/debug.umd.js 3.93 kB
devtools/dist/devtools.js 260 B
devtools/dist/devtools.mjs 274 B
devtools/dist/devtools.module.js 274 B
devtools/dist/devtools.umd.js 346 B
hooks/dist/hooks.js 1.54 kB
hooks/dist/hooks.mjs 1.57 kB
hooks/dist/hooks.module.js 1.57 kB
hooks/dist/hooks.umd.js 1.61 kB
jsx-runtime/dist/jsxRuntime.js 1.01 kB
jsx-runtime/dist/jsxRuntime.mjs 985 B
jsx-runtime/dist/jsxRuntime.module.js 985 B
jsx-runtime/dist/jsxRuntime.umd.js 1.08 kB
test-utils/dist/testUtils.js 473 B
test-utils/dist/testUtils.mjs 477 B
test-utils/dist/testUtils.module.js 477 B
test-utils/dist/testUtils.umd.js 555 B

compressed-size-action

@JoviDeCroock JoviDeCroock merged commit 4d40e96 into v10.x Nov 29, 2025
14 checks passed
@JoviDeCroock JoviDeCroock deleted the backport-some-v11-optimizations branch November 29, 2025 13:19
@JoviDeCroock JoviDeCroock mentioned this pull request Nov 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rschristian rschristian rschristian approved these changes

@marvinhagemeister marvinhagemeister Awaiting requested review from marvinhagemeister

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JoviDeCroock @rschristian @ali-garajian