ENH: Period comparisons with mismatched freq use py3 behavior #39274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Jan 19, 2021
jbrockmendel
commented
- closes #xxxx
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
jreback
requested changes
Jan 19, 2021
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
lgtm. minor comments. ping on green.
| diff = PeriodIndex(["2011-02", "2011-01", "2011-04", "NaT"], freq="4M") | ||
| msg = "Input has different freq=4M from Period(Array|Index)" | ||
| with pytest.raises(IncompatibleFrequency, match=msg): | ||
| msg = rf"Invalid comparison between dtype=period\[{freq}\] and PeriodArray" |
Contributor
There was a problem hiding this comment.
prob should either rename the tests slightly or separate out the == case (and test != as well)
Member
Author
There was a problem hiding this comment.
will rename for now. i think we may be able to re-use a helper from the dt64 tests, will take a look before long
jreback
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.