API/BUG: treat different UTC tzinfos as equal #39216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jbrockmendel
commented
Jan 16, 2021
jbrockmendel
commented
- closes tz_compare fails to consider string "UTC" and pytz UTC object equal #23959
- tests added / passed
- Ensure all linting tests pass, see here for how to run them
- whatsnew entry
mroeschke
reviewed
Jan 19, 2021
| bool | ||
| """ | ||
| # GH 18523 | ||
| if is_utc(start): |
Member
There was a problem hiding this comment.
Could we add a test to ensure all the components of the utc_fixture are equivalent?
Member
Author
There was a problem hiding this comment.
just tried this and we have several utc_fixture members that arent recognized by is_utc, will need to fix that separately
jreback
requested changes
Jan 19, 2021
Contributor
jreback
left a comment
jreback
left a comment
There was a problem hiding this comment.
can you add a whatsnew note (bug fix ok). any perf diffs here?
Member
Author
updated
tz_compare checks will be slightly slower, but we'll avoid casting to object in a few cases. not much |
jreback
approved these changes
Jan 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.