-
Notifications
You must be signed in to change notification settings - Fork 42
NE-2191: Adding int pipeline run + custom pipeline definition #301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
@Thealisyed: This pull request references NE-2191 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
87846c6 to
8c1f4d7
Compare
e3cfdb0 to
df79ab1
Compare
96520bb to
1670f55
Compare
fb9fe7a to
bee5448
Compare
bee5448 to
de2c062
Compare
acb33cb to
e7cfa7d
Compare
alebedev87
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another look. The pipeline deploys the operator, it's very good, let's fix the pushing of the artifacts now.
|
|
||
| # Copy the EDO FBC catalog (OCP version-based) | ||
| COPY catalog/v4.21/catalog.yaml /configs/external-dns-operator/catalog.yaml | ||
| COPY catalog/v4.19/catalog.yaml /configs/external-dns-operator/catalog.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not needed anymore. The test is supposed to be run on 4.19 as ITS is not linked to 4.19 FBC.
adding the secret to push artifacts
| # /bin/opm (with a serve subcommand) and /bin/grpc_health_probe | ||
| # Note: The base image version should match the targeted OCP version | ||
| FROM registry.redhat.io/openshift4/ose-operator-registry-rhel9:v4.21 | ||
| FROM registry.redhat.io/openshift4/ose-operator-registry-rhel9:v4.19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change? ITS is linked to 4.19 FBC.
| value: main | ||
| - name: pathInRepo | ||
| value: stepactions/fail-if-any-step-failed/0.1/fail-if-any-step-failed.yaml | ||
| - name: verify-image-sources |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can remove this task for the moment because all we needed was done in deploy-operator task.
| - name: pathInRepo | ||
| value: .tekton/pipelines/deploy-fbc-operator.yaml | ||
| - name: CREDENTIALS_SECRET_NAME | ||
| value: ext-dns-optr-fbc-v9-19-pull |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| value: ext-dns-optr-fbc-v9-19-pull | |
| value: ext-dns-optr-fbc-v4-21-pull |
|
@Thealisyed: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Adding the integration test pipeline run + a customized pipeline definition to external-dns-operator for the FBC Integration testing
Pipeline run from konflux-ci
Pipelines deploy yaml from Konflux ci