Skip to content

Conversation

@Thealisyed
Copy link

Adding the integration test pipeline run + a customized pipeline definition to external-dns-operator for the FBC Integration testing

Pipeline run from konflux-ci

Pipelines deploy yaml from Konflux ci

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 13, 2025
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 13, 2025

@Thealisyed: This pull request references NE-2191 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set.

In response to this:

Adding the integration test pipeline run + a customized pipeline definition to external-dns-operator for the FBC Integration testing

Pipeline run from konflux-ci

Pipelines deploy yaml from Konflux ci

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from alebedev87 and candita November 13, 2025 11:31
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 13, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign davidesalerno for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Nov 28, 2025
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 1, 2025
Copy link
Contributor

@alebedev87 alebedev87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another look. The pipeline deploys the operator, it's very good, let's fix the pushing of the artifacts now.


# Copy the EDO FBC catalog (OCP version-based)
COPY catalog/v4.21/catalog.yaml /configs/external-dns-operator/catalog.yaml
COPY catalog/v4.19/catalog.yaml /configs/external-dns-operator/catalog.yaml
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not needed anymore. The test is supposed to be run on 4.19 as ITS is not linked to 4.19 FBC.

adding the secret to push artifacts
# /bin/opm (with a serve subcommand) and /bin/grpc_health_probe
# Note: The base image version should match the targeted OCP version
FROM registry.redhat.io/openshift4/ose-operator-registry-rhel9:v4.21
FROM registry.redhat.io/openshift4/ose-operator-registry-rhel9:v4.19
Copy link
Contributor

@alebedev87 alebedev87 Dec 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change? ITS is linked to 4.19 FBC.

value: main
- name: pathInRepo
value: stepactions/fail-if-any-step-failed/0.1/fail-if-any-step-failed.yaml
- name: verify-image-sources
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this task for the moment because all we needed was done in deploy-operator task.

- name: pathInRepo
value: .tekton/pipelines/deploy-fbc-operator.yaml
- name: CREDENTIALS_SECRET_NAME
value: ext-dns-optr-fbc-v9-19-pull
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
value: ext-dns-optr-fbc-v9-19-pull
value: ext-dns-optr-fbc-v4-21-pull

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Dec 5, 2025

@Thealisyed: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator e41d682 link true /test e2e-aws-operator

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants