test: fix 'after' fixture next version range #3324
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
added
the
test all versions
Contributor
📊 Package size report No changes
Unchanged files
🤖 This report was automatically generated by pkg-size-action |
pieh
commented
Dec 15, 2025
Comment on lines
15
to
20
| "test": { | ||
| "dependencies": { | ||
| "next": "15.1.11" | ||
| "next": ">=15.1.0" | ||
| } | ||
| } | ||
| } |
Contributor
Author
There was a problem hiding this comment.
This defines when RESOLVED_NEXT_VERSION will be used to install version that is different in package.json#depencies.next - because of the pinning this was never satisfied, so it was always installing latest which requires node@20 and cause just build errors when testing v15 (15.5.9).
This is meant to mimic range used in test themselves - in particular here it needs to match
opennextjs-netlify/tests/e2e/after.test.ts
Lines 5 to 6 in fb87ac7
pieh
force-pushed
the
test/fix-after-fixture-reqs
branch
from
3dd167f to
dda370b
Compare
pieh
commented
Dec 15, 2025
pieh
commented
Dec 15, 2025
| 'after', | ||
| 'cli-before-regional-blobs-support', | ||
| 'dist-dir', | ||
| 'dynamic-cms', |
Contributor
Author
There was a problem hiding this comment.
not related, but noticed we do prepare this fixture for integration tests, but we only use them in e2e - so prebuilding is not needed (and might safe some disk usage which has some problems now)
mrstork
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The pinning of version in fixture's
package.json#test.dependencies.nextresults in attempt to uselatestwhen running against 15.5.9, which will never allow the fixture the build, because it requeires node@20 for next@16, while node@18 is used for tests targeted at versions below 16Note: there are known ENOSPC problems in test setup - this PR intentionally is not trying to address those (there was early attempt, but it was not succesful, so to not keep changes from this PR hostage on that - this only do simple fixes/adjustments and ENOSPC will have separate PR most likely)