Skip to content

Conversation

@dmathieu
Copy link
Member

This adds obs metrics to the profiles receivers.

@dmathieu dmathieu force-pushed the receiverhelper-profiles-metrics branch from 905cff1 to 15b8b14 Compare November 27, 2025 11:35
@codspeed-hq
Copy link

codspeed-hq bot commented Nov 27, 2025

CodSpeed Performance Report

Merging #14226 will degrade performances by 28.91%

Comparing dmathieu:receiverhelper-profiles-metrics (6bfb0f5) with main (2e5bb6d)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

❌ 3 regressions
✅ 56 untouched
⏩ 20 skipped1

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
BenchmarkTraceSizeBytes 309 µs 434.7 µs -28.91%
BenchmarkTracesToProto2k 69 µs 95.8 µs -27.97%
BenchmarkLogsToProto2k 45 µs 63.1 µs -28.76%

Footnotes

  1. 20 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@dmathieu dmathieu marked this pull request as ready for review November 27, 2025 11:42
@dmathieu dmathieu requested a review from a team as a code owner November 27, 2025 11:42
@dmathieu dmathieu requested a review from jmacd November 27, 2025 11:42
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.15%. Comparing base (2e5bb6d) to head (6bfb0f5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14226      +/-   ##
==========================================
- Coverage   92.15%   92.15%   -0.01%     
==========================================
  Files         668      668              
  Lines       41513    41585      +72     
==========================================
+ Hits        38257    38323      +66     
- Misses       2219     2223       +4     
- Partials     1037     1039       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@rogercoll rogercoll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small nit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants