Skip to content

Conversation

@alex-courtis
Copy link
Member

@alex-courtis alex-courtis commented Mar 7, 2023

fixes #2011

Requires dogfooding

  • api.tree.find_file feature parity
  • commands call API
  • large refactor of open, toggle, find_file

find-file

legacy path        - x - - - - - - - - -
buf path           - - x - x - - - - - -
buf number         - - - x - - - - - - -
open               - - - - x x - - x x -
current_window     - - - - - x - - - x -
update_root        - - - - - - x - - - x
focus              - - - - - - - x x x -
ignore_list        - - - - - - - - - - x

open

path               x - - - - - - - - x x x x
current_window     - x - - - - x x x - x x x
find_file          - - x - x x x x x x x x x
update_root        - - - x x x - x x - - x x
ignore_list        - - - - - x - - x - - - x

toggle

path               - x - - - - - - - - - -
current_window     - - x - - - - x x x x -
find_file          - - - x - x - x x - - x
update_root        - - - - x x - - x - x x
! focus            - - - - - - x - - x - -
ignore_list        - - - - - - - - - - - x

@alex-courtis alex-courtis marked this pull request as draft March 7, 2023 04:23
@alex-courtis alex-courtis marked this pull request as ready for review March 7, 2023 04:58
@alex-courtis alex-courtis merged commit fe980ba into master Mar 13, 2023
@alex-courtis alex-courtis deleted the 2011-api.tree.find_file-feature-parity branch March 13, 2023 05:53
@sarmong
Copy link
Collaborator

sarmong commented Mar 21, 2023

Please, mark the commit with ! or BREAKING CHANGE if it breaks the existing api.

@alex-courtis
Copy link
Member Author

Please, mark the commit with ! or BREAKING CHANGE if it breaks the existing api.

There was no intention to break the API; nvim-tree has promised non-breaking.

That issue is a bug and will be fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

api.tree.find_file feature parity

3 participants