Update docker commands. #940
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvbn
reviewed
Aug 19, 2019
Owner
nvbn
left a comment
nvbn
left a comment
There was a problem hiding this comment.
Thanks, looks good, I've added a few review comments.
thefuck/rules/docker_not_command.py
Outdated
| @sudo_support | ||
| def get_new_command(command): | ||
| if 'Usage:' in command.output and len(command.script_parts) > 1: | ||
| management_subcommands = _parse_commands(map(lambda x: x + '\n', command.output.split('\n')), 'Commands:\n') |
Owner
There was a problem hiding this comment.
I think it might be better to replace map(lambda x: x + '\n', command.output.split('\n')) with just command.output.split('\n') and replace lambda line: line != '\n' in :17 with lambda line: line.strip(), so it will handle both '\n' and ''.
| ''' | ||
|
|
||
|
|
||
| @pytest.fixture(autouse=True) |
Owner
There was a problem hiding this comment.
There's already no_memoize fixture - https://github.com/nvbn/thefuck/blob/master/tests/conftest.py#L17
Contributor
Author
|
I appreciate the suggestions, @nvbn. |
Owner
|
Cool, thanks! |
riley-martine
pushed a commit
to riley-martine/thefuck
that referenced
this pull request
Dec 7, 2023
* Add: Tests for newer version docker support. * Add: Support for newer versions of docker (Modified rules.docker_not_command). * Fix: Updated disabling memoize. * Change: removed empty list check. * Fix: _parse_commands now uses line.strip() internally and ends_with arg now doesn't end with newline. * Change: Replaced disable_memoize in favor of no_memoize fixture. * Fix: removed unused import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Newer version of docker outputs its result to stderr, not stdout.
Also, docker's command has been changed a lot (for example,
docker imagesis nowdocker image ls).resolve #937