Skip to content

Conversation

@Epse
Copy link
Contributor

@Epse Epse commented Oct 5, 2017

This PR contains basic support for DNF the Fedora package manager.

It contains a new specific, which only contains a variable dnf_available, very similar to thefuck.specific.apt.apt_available.

Also there is a dnf_no_such_command rule that parses DNF's help output for commands and autofixes your input. It is enabled based on the dnf_available value.

flake8 had no complaints about my code, but if you do, I'd welcome the advice!

@scorphus
Copy link
Collaborator

scorphus commented Oct 6, 2017

Nice! This one also lacks a proper test and a line in README.md explaining the new rule. Can you please add both? Thanks!

@Epse
Copy link
Contributor Author

Epse commented Oct 6, 2017

I assumed I shouldn't touch the README. Oh well, I'll fix it

@scorphus
Copy link
Collaborator

scorphus commented Oct 6, 2017

Looking good.

How about tests?

@Epse
Copy link
Contributor Author

Epse commented Oct 7, 2017

On their way. Running into a couple of issues where tests are failing but the same deal actually typed and fucked in a terminal works... Seems to be due to byte strings and regular strings

@Epse
Copy link
Contributor Author

Epse commented Oct 7, 2017

There are now tests!

@nvbn
Copy link
Owner

nvbn commented Oct 8, 2017

Thanks!

@nvbn nvbn merged commit f333dfe into nvbn:master Oct 8, 2017
riley-martine pushed a commit to riley-martine/thefuck that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants