Commit e29ed1d
authored
Fix errors in linker output when building ARM64EC (#19331)
Summary of the issue:
When building NVDA with Visual Studio 2026, errors are printed when linking ARm64EC:
build\arm64ec\local\nvdaHelperLocal.def : error LNK1397: '?_nvdaController_speakText@@3P6AKPEB_W@ZEA' is an invalid name for a function export, treating it as a data export. (Did you forget 'DATA' in the .def file?)
build\arm64ec\local\nvdaHelperLocal.def : error LNK1397: '?_nvdaControllerInternal_handleRemoteURL@@3P6AKPEB_W@ZEA' is an invalid name for a function export, treating it as a data export. (Did you forget 'DATA' in the .def file?)
build\arm64ec\local\nvdaHelperLocal.def : error LNK1397: '?_nvdaControllerInternal_reportLiveRegion@@3P6AKPEB_W0@ZEA' is an invalid name for a function export, treating it as a data export. (Did you forget 'DATA' in the .def file?)
build\arm64ec\local\nvdaHelperLocal.def : error LNK1397: '?_nvdaController_cancelSpeech@@3P6AKXZEA' is an invalid name for a function export, treating it as a data export. (Did you forget 'DATA' in the .def file?)
build\arm64ec\local\nvdaHelperLocal.def : error LNK1397: '?_nvdaControllerInternal_inputCompositionUpdate@@3P6AKPEB_WHHH@ZEA' is an invalid name for a function export, treating it as a data export. (Did you forget 'DATA' in the .def file?)
build\arm64ec\local\nvdaHelperLocal.def : error LNK1397: '?_nvdaControllerInternal_inputConversionModeUpdate@@3P6AKJJK@ZEA' is an invalid name for a function export, treating it as a data export. (Did you forget 'DATA' in the .def file?)
Description of user facing changes:
None
Description of developer facing changes:
No longer errors when building NVDA.
Description of development approach:
Do as the linker suggests, explicitly mark non-function exports with the DATA keyword1 parent 39e499b commit e29ed1d
1 file changed
+21
-21
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
5 | | - | |
| 4 | + | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
40 | | - | |
41 | | - | |
42 | | - | |
43 | | - | |
44 | | - | |
45 | | - | |
46 | | - | |
47 | | - | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | | - | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
55 | 55 | | |
56 | | - | |
| 56 | + | |
57 | 57 | | |
58 | 58 | | |
59 | 59 | | |
| |||
70 | 70 | | |
71 | 71 | | |
72 | 72 | | |
73 | | - | |
74 | | - | |
| 73 | + | |
| 74 | + | |
75 | 75 | | |
76 | 76 | | |
77 | 77 | | |
| |||
0 commit comments