Skip to content

Conversation

@huang-julien
Copy link
Member

@huang-julien huang-julien commented Jul 14, 2024

πŸ”— Linked issue

fix #133

❓ Type of change

This PR remove the generated TS file and move it into virtual but still generate a declaration file for composables. It also move TPC generation into a single function for better maintenance.

This has been tested with turnstile locally for the build issue and the script registry option isn't broken

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

@vercel
Copy link

vercel bot commented Jul 14, 2024

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
scripts-docs βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 14, 2024 5:37pm
scripts-playground βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 14, 2024 5:37pm

@huang-julien huang-julien requested a review from harlan-zw July 14, 2024 17:37
@huang-julien huang-julien changed the title refactor(tpc): write only type files refactor(tpc): write only declaration files Jul 14, 2024
@harlan-zw harlan-zw merged commit 29c83fc into main Jul 15, 2024
@harlan-zw harlan-zw deleted the refactor/generate_typefile_fortpc branch July 15, 2024 03:11
@harlan-zw
Copy link
Collaborator

Thank you ❀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(tpc): a type annotation is necessary

3 participants