Skip to content

refactor(tpc): remove augmentWindowTypes #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
harlan-zw merged 2 commits into from
Jul 1, 2024
Merged

refactor(tpc): remove augmentWindowTypes #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b3bbbd
refactor(tpc): remove augmentWindowTypes
huang-julien Jun 30, 2024
f88813f
chore: lint
huang-julien Jun 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/tpc/google-analytics.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export default function googleAnalitycsRegistry() {
},
tpcKey: 'gtag',
tpcTypeImport: 'GoogleAnalyticsApi',
augmentWindowTypes: true,
})
},
filename: 'nuxt-scripts/tpc/google-analytics.ts',
Expand Down
1 change: 0 additions & 1 deletion src/tpc/google-tag-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ export default function googleTagManagerRegistry() {
},
tpcKey: 'gtm',
tpcTypeImport: 'GoogleTagManagerApi',
augmentWindowTypes: true,
})
},
filename: 'nuxt-scripts/tpc/google-tag-manager.ts',
Expand Down
5 changes: 1 addition & 4 deletions src/tpc/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@ export interface ScriptContentOpts {
data: Output
scriptFunctionName: string
tpcTypeImport: string
augmentWindowTypes?: boolean
tpcKey: string
/**
* This will be stringified. The function must be pure.
Expand Down Expand Up @@ -56,12 +55,10 @@ export function getTpcScriptContent(input: ScriptContentOpts) {
chunks.push(`const OptionSchema = object({${mainScript.params?.map(p => `${p}: any()`)}})`)
}

if (input.augmentWindowTypes) {
chunks.push(`
chunks.push(`
declare global {
interface Window extends ${input.tpcTypeImport} {}
}`)
}

const clientInitCode: string[] = []

Expand Down
3 changes: 0 additions & 3 deletions test/unit/tpc.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ describe.each([
},
tpcKey: 'google-analytics',
tpcTypeImport: 'GoogleAnalyticsInput',
augmentWindowTypes: true,
scriptFunctionName: 'useScriptGoogleAnalytics',
use: () => { },
stub: () => { },
Expand All @@ -60,7 +59,6 @@ describe.each([
},
tpcKey: 'google-analytics',
tpcTypeImport: 'GoogleAnalyticsInput',
augmentWindowTypes: true,
scriptFunctionName: 'useScriptGoogleAnalytics',
use: () => {
return { dataLayer: window.dataLayer, gtag: window.gtag }
Expand Down Expand Up @@ -141,7 +139,6 @@ describe('script content generation with head positioning', () => {
},
tpcKey: 'google-analytics',
tpcTypeImport: 'GoogleAnalyticsInput',
augmentWindowTypes: true,
scriptFunctionName: 'useScriptGoogleAnalytics',
use: () => { },
stub: () => { },
Expand Down