-
-
Notifications
You must be signed in to change notification settings - Fork 7.2k
fix the abi tests for diagnostics positions feature #4572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nlohmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
|
Thanks! We really need to add a CI step for this... |
|
Yes, I will raise a PR for a CI step as well. |
That would be the place to add the change: https://github.com/nlohmann/json/blob/develop/cmake/ci.cmake#L894_L955 Target |
Okay sounds good, thanks for the link. |
Added with #4579. |
This PR changes fix the issue #4571, when 'JSON_Diagnostic_Positions' cmake option is enabled, we need to cover JSON_DIAGNOSTIC_POSITIONS preprocessor directive as well.
Pull request checklist
Read the Contribution Guidelines for detailed information.
include/nlohmanndirectory, runmake amalgamateto create the single-header filessingle_include/nlohmann/json.hppandsingle_include/nlohmann/json_fwd.hpp. The whole process is described here.