Skip to content

Fix spellcheck issue #4173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nlohmann merged 1 commit into from
Oct 4, 2023
Merged

Fix spellcheck issue #4173

nlohmann merged 1 commit into from
Oct 4, 2023

Conversation

@mwestphal
Copy link
Contributor

@mwestphal mwestphal commented Oct 3, 2023 •
edited
Loading

Fix spellcheck issue, you may want to add a spellcheck action on your CI.

Detected in f3d-app/f3d#1034

Pull request checklist

Read the Contribution Guidelines for detailed information.

  • Changes are described in the pull request, or an existing issue is referenced.
  • The test suite compiles and runs without error.
  • Code coverage is 100%. Test cases can be added by editing the test suite.
  • The source code is amalgamated; that is, after making changes to the sources in the include/nlohmann directory, run make amalgamate to create the single-header files single_include/nlohmann/json.hpp and single_include/nlohmann/json_fwd.hpp. The whole process is described here.

@mwestphal mwestphal requested a review from nlohmann as a code owner October 3, 2023 21:24
@coveralls
Copy link

coveralls commented Oct 4, 2023

Coverage Status

coverage: 100.0%. remained the same when pulling 59bd76c on mwestphal:fix_spellcheck into 35c0b3e on nlohmann:develop.

nlohmann
nlohmann approved these changes Oct 4, 2023
View reviewed changes
Copy link
Owner

@nlohmann nlohmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@nlohmann nlohmann added this to the Release 3.11.3 milestone Oct 4, 2023
@nlohmann nlohmann merged commit 6adae02 into nlohmann:develop Oct 4, 2023
@nlohmann
Copy link
Owner

nlohmann commented Oct 4, 2023

Thanks!

@nlohmann nlohmann mentioned this pull request Nov 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nlohmann nlohmann nlohmann approved these changes

Assignees

No one assigned

Labels

S tests

Projects

None yet

Milestone

Release 3.11.3

Development

Successfully merging this pull request may close these issues.

3 participants

@mwestphal @coveralls @nlohmann